Skip to content

iOS: don't override EXCLUDED_ARCHS when installing Hermes #39060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpdriver wants to merge 4 commits into from
+68 −12
Closed

iOS: don't override EXCLUDED_ARCHS when installing Hermes #39060

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba5bf2e
iOS: don't override excluded archs when installing Hermes
jpdriver Aug 17, 2023
a54a23d
fixup logic
jpdriver Aug 19, 2023
9ee6b07
add new tests
jpdriver Aug 19, 2023
9e047d2
address PR comments
jpdriver Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/react-native/scripts/cocoapods/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,14 @@ def self.turn_off_resource_bundle_react_core(installer)
def self.exclude_i386_architecture_while_using_hermes(installer)
projects = self.extract_projects(installer)

# Hermes does not support `i386` architecture
excluded_archs_default = self.has_pod(installer, 'hermes-engine') ? "i386" : ""

projects.each do |project|
project.build_configurations.each do |config|
config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = excluded_archs_default
currentValue = config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] || ""

unless currentValue.include?("i386")
# Hermes does not support `i386` architecture
config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "#{currentValue} i386".strip
end
end

project.save()
Expand Down