resizeMode applies to Image.defaultSource #22216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
dulmandakh
changed the title
|
just dug a little bit, and found proper solution 👍 |
radko93
approved these changes
Nov 8, 2018
|
@hramos please review and merge |
|
You should ask release notes (look into new PR template). |
|
Hey @dulmandakh can you add the release notes to the post - then I'll try to trigger the import. |
|
@kelset done |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit 673ef39 into |
kelset
pushed a commit
that referenced
this pull request
Nov 26, 2018
Summary: resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource. Changelog: ---------- [Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading. Pull Request resolved: #22216 Differential Revision: D13088220 Pulled By: mdvacca fbshipit-source-id: 92c66cf6228f3b7666b9ef2404d034f0005b5234
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource. Changelog: ---------- [Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading. Pull Request resolved: facebook#22216 Differential Revision: D13088220 Pulled By: mdvacca fbshipit-source-id: 92c66cf6228f3b7666b9ef2404d034f0005b5234
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource.
Changelog:
[Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading.