From d96d194c612fcede1bae9e1516250866f207a41b Mon Sep 17 00:00:00 2001 From: Simon Bengtsson Date: Sat, 28 Oct 2017 16:33:12 +0200 Subject: [PATCH 1/2] Update IntegrationWithExistingApps.md Make sure a recent version of react native is used by default. Otherwise an old 0.20.1 version hosted in [jcenter](https://bintray.com/bintray/jcenter/com.facebook.react%3Areact-native) might override the version included from `node_modules`. --- docs/IntegrationWithExistingApps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/IntegrationWithExistingApps.md b/docs/IntegrationWithExistingApps.md index b3aa09efb1e684..34025d7257f0a4 100644 --- a/docs/IntegrationWithExistingApps.md +++ b/docs/IntegrationWithExistingApps.md @@ -555,7 +555,7 @@ Add the React Native dependency to your app's `build.gradle` file: dependencies { compile 'com.android.support:appcompat-v7:23.0.1' ... - compile "com.facebook.react:react-native:+" // From node_modules. + compile "com.facebook.react:react-native:0.49+" // From node_modules. } ``` From 1d39aee2d92ce0b597d387f84d12073d8676226d Mon Sep 17 00:00:00 2001 From: Simon Bengtsson Date: Thu, 9 Nov 2017 09:57:56 +0100 Subject: [PATCH 2/2] Update IntegrationWithExistingApps.md Revert version constraint and instead add note about where jcenter() goes. --- docs/IntegrationWithExistingApps.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/IntegrationWithExistingApps.md b/docs/IntegrationWithExistingApps.md index 34025d7257f0a4..2176ff2eb1df76 100644 --- a/docs/IntegrationWithExistingApps.md +++ b/docs/IntegrationWithExistingApps.md @@ -555,7 +555,7 @@ Add the React Native dependency to your app's `build.gradle` file: dependencies { compile 'com.android.support:appcompat-v7:23.0.1' ... - compile "com.facebook.react:react-native:0.49+" // From node_modules. + compile "com.facebook.react:react-native:+" // From node_modules. } ``` @@ -566,11 +566,11 @@ Add an entry for the local React Native maven directory to `build.gradle`. Be su ``` allprojects { repositories { - ... maven { // All of React Native (JS, Android binaries) is installed from npm url "$rootDir/../node_modules/react-native/android" } + ... // Other maven repostories such as jcenter() goes here } ... }