[iOS] RCTWebSocket does not build on Xcode Version 8.0 beta (8S128d)

[ppong]

Does anyone have problem building React Native on the Xcode 8.0 beta?

Yeah same Problem

[HughLi]

Same Problem +1

[finalquest]

Yep. In iOS 10, SecRandomCopyBytes has a new attribute
attribute ((warn_unused_result)).

[nickstamas]

How should we handle this? Has anyone had luck building for iOS10? I saw @vjeux's tweet here and was hoping that change was the only one needed.

[mskalra]

Not sure if this is the right fix but I was able to get around this by casting SecRandomCopyBytes as void:

(void)SecRandomCopyBytes(kSecRandomDefault, keyBytes.length, keyBytes.mutableBytes);
(void)SecRandomCopyBytes(kSecRandomDefault, sizeof(uint32_t), (uint8_t *)mask_key);

This + what nickstamas linked was enough to get it to build and deploy on ios10.

[nickstamas]

@mskalra With the combination of the changes to RCTScrollView and RCTSRWebSocket, I can get an app to build, but I'm seeing a lot of console output like this:

nw_endpoint_flow_protocol_disconnected [1.1 ::1.8081 cancelled socket-flow (null)] Output protocol disconnected

There's other weirdness too. I have to run the packager manually, it doesn't run automatically when I hit Play in Xcode. Also, the app seems unresponsive in the Simulator.

[mskalra]

@nickstamas strange, it seems to build and deploy like normal for me, both on my device and in the simulator.

Will probably have to wait for an official fix.. Shouldn't be too long hopefully. Good luck!

[stefanfisk]

Wrapping SecRandomCopyBytes() with a call to assert(0 == ...) is probably a marginally better idea, so that if it against all odds fails it does not do so silently.

[batuhan]

Is there an update on this?

[ammichael]

I've tried @mskalra solution, and it seems to work.. but then I've received another error related to RCTScrollView:

[mskalra]

@ammichael add these changes as well and you should be good: 7c8b914

[ammichael]

@mskalra Well, it did helped to stop building errors, but when it runs in simulator,
the screen is scaled down and I'm receiving errors.

I've created a gist with the Xcode and RN Packager logs: https://gist.github.com/ammichael/0c7c915216c30c7d156ffb3bc44f938d

Here how the screen is scaled:

[javache]

Could you please send a pull-request with these changes? Thanks!