ES6 style import text inside of string breaks packager

[jaulz]

// assign test to the string "import test from 'test'"
var test = `import test from 'test'`

It seems that as soon as you try to have a variable that contains the string to import a module the packer breaks. It's really easy to reproduce: https://rnplay.org/apps/FBm0LQ
The obvious workaround is to have a variable that concatenates the string but does that make sure that there are no other side effects?

[satya164]

cc @martinbigio

[brentvatne]

Also cc @cpojer

[cpojer]

We don't use static analysis to analyze dependencies but rather just regex, for performance reasons. Unfortunately that means we can't ignore strings that look like imports/require's. As you suggested, the workaround is string concatenation.

[jaulz]

Thanks for the quick answers and good to know :)
@cpojer any hint where I can find that part of the code?

[cpojer]

All of this is in https://github.com/facebook/node-haste :)