-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] E2E tests are failing because of Babel 6 not being able to find its plugins #4137
Comments
Thanks for looking into it James! Tadeu found out it's a bug in Babel and Sebastian is going to fix it. That way we can cut the next release branch. |
Nice work London team :) |
I'm having a lot of difficulty trying to run the tests:
Is there any instructions on how to actually setup a local React Native dev environment? |
@sebmck It looks like you need to install Xcode and set up the iOS development environment. Your Node version and nvm setup look fine. |
@ide Are there any instructions anywhere? Having a hard time debugging this because I've never done iOS/mobile dev before. |
@sebmck - I believe that all you need to do is download XCode through the App Store |
Looks like I forgot to actually open Xcode and install the required components... Thanks for the help! |
I can't reproduce this locally so this looks like it's just a Travis environment issue? Full log here. |
If you revert c6a3052 I think the issue will resurface if invoke You might want to try with Node 4.2.2 (just a different .nvm install without all your global modules, in case those are affecting things)? |
Same thing with Node 4. I reverted that commit and the tests also ran successfully, log here. |
The E2E test fails for me on master: https://gist.github.com/ide/60a5fb5a5352226a4e1e. On master, this is what I get when running $ git revert c6a3052
$ nvm use default
Now using node v4.2.1 (npm v2.14.7)
$ npm i
npm WARN prefer global [email protected] should be installed with -g
> [email protected] install /Users/ide/Code/react-native/node_modules/fsevents
> node-pre-gyp install --fallback-to-build
[fsevents] Success: "/Users/ide/Code/react-native/node_modules/fsevents/lib/binding/Release/node-v46-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile
$ cd ..
$ react-native/packager/launchPackage.command
/Users/ide/Code/react-native/node_modules/babel-core/lib/transformation/file/options/option-manager.js:181
throw new ReferenceError(messages.get("pluginUnknown", plugin, loc, i));
^
ReferenceError: Unknown plugin "syntax-async-functions" specified in "foreign" at 0
at /Users/ide/Code/react-native/node_modules/babel-core/lib/transformation/file/options/option-manager.js:181:17
at Array.map (native)
at Function.normalisePlugins (/Users/ide/Code/react-native/node_modules/babel-core/lib/transformation/file/options/option-manager.js:163:20)
at OptionManager.mergeOptions (/Users/ide/Code/react-native/node_modules/babel-core/lib/transformation/file/options/option-manager.js:259:36)
at compile (/Users/ide/Code/react-native/node_modules/babel-register/lib/node.js:87:15)
at loader (/Users/ide/Code/react-native/node_modules/babel-register/lib/node.js:128:14)
at Object.require.extensions.(anonymous function) [as .js] (/Users/ide/Code/react-native/node_modules/babel-register/lib/node.js:138:7)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:311:12)
at Module.require (module.js:366:17)
Process terminated. Press <enter> to close the window My suspicion is that something about your PATH or global node_modules is different than mine and you might have Babel plugins in places that I don't. |
Was able to repro with those commands, thanks @ide! Just pushed out 6.2.0 that should fix this. Sorry for the delay in getting this fixed. |
@sebmck awesome! Thank you for looking into this. cc @tadeuzagallo @mkonicek could you guys update node_modules and npm-shrinkwrap.json? The upgrade should be quite straightforward and not require extra effort to get things working (only minor version updates of Babel). |
Logs:
cc @tadeuzagallo @frantic
I updated Babel and the plugins just in case it would fix things, but it didn't: https://travis-ci.org/facebook/react-native/builds/91186532.
Babel shouldn't be this hard to get running correctly. Perhaps Babel 6's algorithm for resolving plugins should be patched to include Babel 5's behavior?
The text was updated successfully, but these errors were encountered: