Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatusBarIOS removed but statusBarFrameWillChange event not yet available in StatusBar #32297

Closed
danielgindi opened this issue Sep 29, 2021 · 6 comments
Closed

StatusBarIOS removed but statusBarFrameWillChange event not yet available in StatusBar #32297

danielgindi opened this issue Sep 29, 2021 · 6 comments
Labels
Component: StatusBar Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@danielgindi
Copy link
Contributor

danielgindi commented Sep 29, 2021 •
edited
Loading

Version

0.66.0-rc.4

Build Target(s)

iOS 15

Developer Environment

iOS / Xcode

Issue and Reproduction Steps

Previously we could have done this:

StatusBarIOS.addListener('statusBarFrameWillChange', ...)
StatusBarIOS.addListener('statusBarFrameDidChange', ...)

To get status bar frame change events on iOS.
Now the event still exists - in native code - but not accessible anymore as it has not migrated when deprecating StatusBarIOS.

So this is not only a breaking change, but a breaking change without an alternative.
danielgindi referenced this issue Sep 29, 2021
@ecreeth @facebook-github-bot
refactor!: drop deprecated StatusBarIOS (#31466)
7ce0f40 
Summary:
This component has been merged with `StatusBar` and deprecated since [Jun 24, 2019](a833778)

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[JavaScript] [Removed] - refactor!: drop deprecated `StatusBarIOS`

Pull Request resolved: #31466

Test Plan: Warning when user imports `StatusBarIOS`

Reviewed By: yungsters

Differential Revision: D30109324

Pulled By: lunaleaps

fbshipit-source-id: fa2d3aa2cf35206ed8a196e09f12af57d3b61ccc
@lunaleaps
Copy link
Contributor

@danielgindi StatusBarIOS is a lean-core component that has been slotted for removal for some time and to be replaced with StatusBar. Is your issue here that StatusBar does not have the same listener?

@danielgindi
Copy link
Contributor Author

@danielgindi StatusBarIOS is a lean-core component that has been slotted for removal for some time and to be replaced with StatusBar. Is your issue here that StatusBar does not have the same listener?

Exactly

@lunaleaps
Copy link
Contributor

Okay, I would categorize this not as a release blocking issue then but rather an issue on StatusBar since the plans to deprecate StatusBarIOS have been out for some time. I'll remove the pre-release tag for now and feel free to submit a PR adding the functionality. There might even be similar issues reported

@a-tokyo
Copy link

a-tokyo commented Jan 28, 2022

@lunaleaps This has been blocking us from upgrading for quite a while! ( : Is there a way we can get around this temporarily till a solution is out?

This was referenced Jan 28, 2022
Open
Closed
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Mar 23, 2024
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: StatusBar Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielgindi @lunaleaps @a-tokyo