-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status Bar Dark Content Not Working On iOS 13 Dark Mode #26619
Comments
+1 |
Same here |
As a workaround you could probably update the following keys in the
|
This appears to be the same issue as this #26369 |
I solved the problem. Apple has added a new constant to the status bar with the latest update, so dark-content doesn't work. (in dark-mode) https://developer.apple.com/documentation/uikit/uistatusbarstyle?language=objc New Constant: UIStatusBarStyleDarkContent - A dark status bar, intended for use on light backgrounds.
To Change:
|
Seems to work. Can we expect this to be pushed into RN anytime soon? |
@mronline's solution worked perfectly on RN 0.59.9 |
@mronline's solution worked on RN 0.59.2 🎉 |
So not just an issue with RN 0.60? Hopefully it can be fixed for 59, 60 and 61 then... Monkey patching the xcode file is awful. |
I solved the problem with this commit: 796b3a1
|
for hot fixed react-native file can be used this package https://github.com/ds300/patch-package |
@wphestiraid You made my day! thank you 😃 |
+1 |
This has been fixed in RN 0.61.2 or can be patched as described above. I think this issue can be closed. |
Also please make sure you have this enabled in your
and edit the code to this, so it supports the newest
|
It wrong no add this to info.plist otherwise you receive red box error. |
@fonov I just did that and it works perfectly fine in my iOS 13 device and iOS 13.1.2 as well |
Actually Source: expo/expo#3874 |
Note that now it seems that we need to explicitly set |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information. |
the changes @mronline suggest is very different from the lines of code in my RCTStatusBarManager.m file. My react native version is: 0.63.4, the string fixes mentioned by @gpawlik in info.plist result in the same red error OP has shown. Although it does work and the app does not crash it is still unpleasant to be told its wrong. Im working with iOS 14.6 and Xcode version 12.5 |
React Native version: 0.60.0
Steps To Reproduce
The text was updated successfully, but these errors were encountered: