Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super.componentDidMount not implemented by React.Component #25333

Closed
quantumpotato opened this issue Jun 20, 2019 · 2 comments
Closed

super.componentDidMount not implemented by React.Component #25333

quantumpotato opened this issue Jun 20, 2019 · 2 comments
Labels
Bug Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@quantumpotato
Copy link

0.59.3

Calling super.componentDidMount() crashes on a class that extends Component.
It's weird to have that function be "abstract" in the sense that only subclasses should implement it.

is this intentional?

@react-native-bot
Copy link
Collaborator

Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety?

👉 Click here if you want to take another look at the Bug Report issue template.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels Jun 20, 2019
@dulmandakh
Copy link
Contributor

In React, inheritance is not recommended, please see https://reactjs.org/docs/composition-vs-inheritance.html

@facebook facebook locked as resolved and limited conversation to collaborators Jun 21, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants