Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI file in template #22779

Closed
gengjiawen opened this issue Dec 24, 2018 · 5 comments
Closed

Add CI file in template #22779

gengjiawen opened this issue Dec 24, 2018 · 5 comments
Labels
Contributor A React Native contributor. Partner Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@gengjiawen
Copy link
Contributor

Now we have https://github.com/react-native-community/ci-sample.

I am thinking add ci file default or by some command.

With ci we can handle bug report more easily.

@gengjiawen
Copy link
Contributor Author

Added in #23078.
Removed in #23107.

My thought is that we should more strict about bug report. Through this we can have more communicate efficiency.

cc @kelset @hramos @cpojer

@cpojer
Copy link
Contributor

cpojer commented Jan 30, 2019

Oh yeah I didn't realize. @hramos I thought @gengjiawen's addition was good but maybe I missed something and there is a reason we don't want to recommend it to users who report issues?

@hramos
Copy link
Contributor

hramos commented Jan 30, 2019

Can you clarify what you mean by adding CI to your project, and how this would improve issues?

Sent with GitHawk

@kelset kelset changed the title ["Discussion"] Add ci file in template Add CI file in template Jan 31, 2019
@gengjiawen
Copy link
Contributor Author

adding CI to your project

When user report bug j, build failure or other issue, they need to provide an repro with ci files in it. so we can see the build log and use artifact. There are a sample https://github.com/react-native-community/ci-sample. The sample contains many ci sample user can easily achieve.

how this would improve issues?

By make this more strict, I want to improve the communicate efficiency.

@hramos hramos added Partner Contributor A React Native contributor. and removed Core Team labels Mar 8, 2019
@cpojer
Copy link
Contributor

cpojer commented Mar 19, 2019

We are already asking people for a lot when creating an issue so I think it's best not to ask them to do more. Thanks for your work on this, and the ci-sample is definitely going to be useful to people who work on various React Native things.

@cpojer cpojer closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contributor A React Native contributor. Partner Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

4 participants