-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SectionList][inverted] SectionList headers are sticky-at-the-top-footers if the list is inverted #18945
Comments
try: |
Hi @janicduplessis, you have worked on support of inverted sticky headers, but there are some issues, could you please look at them? |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
Still there is no any workaround or fix for that, so it can't be closed. |
Any workaround on this? |
@iamolegga I just don't use section list with sticky headers currently. Just simply FlatList with custom functions for creating sections and then render it. |
Also struggling with this here, I'm implementing infinite scroll to the top and need sticky headers (or inverted footers, apparently). Any solutions so far? |
I've been able to use this as a workaround:
|
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
This hasn't been fixed yet. |
just simple use renderSectionFooter then header and make inverted true simple |
I'm having the same issue with inverted sticky headers.
This doesn't address the issue. We're looking to have sticky section headers on inverted lists |
+1 |
|
Still an issue on stock installs |
Hey folks 👋 This issue troubled me as I also need the sticky header to work for inverted section list for the app I am building. To solve the problem, I create an https://github.com/LaunchPlatform/inverted-section-list For now I only built it to make it works for my app, didn't test it with other corner cases. My |
Still an issue on stock installs |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Up |
I can't believe this is still an issue after so many years and how common of a design it is in today's apps. |
up |
still an issue... |
Please repair it |
how is this still an issue? is it bc all resources are on the metaverse? |
Is it that hard to implement stickySectionFooterEnabled? |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Still an issue |
After 6 years still an issue |
😀 |
24/04/2024 and still an issue |
28/08/2024 still an issue |
Hey guys, after years, I was working on upgrading RN version of my app and realized this issue is still here 😅 So I tried my best to open a PR for addressing this bug: It appears to be working as I tested, but I am not sure if there's any corner cases I missed. I may also need to find a time to test other platforms, such as iOS. I know this bug troubles us for a very long time, so it would be great if you guys can help me test my PR see if it's working as expected. I have never create a new PR with a major change like this in react-native repo, so I may also need some help. If you know what's missing in my PR, and how to get my PR merged, please let me know. Thank you so much 🙏 |
Hey @fangpenlin, is this ready or still in progress? |
@migueldaipre yep, it's ready for review |
@fangpenlin thanks 👍 also cc @cortinico @cipolleschi |
I've pinged a couple of folks internally to look into this 👍 |
Environment
Environment:
OS: macOS High Sierra 10.13.1
Node: 8.6.0
Yarn: 1.5.1
npm: 4.6.1
Watchman: 4.9.0
Xcode: Xcode 9.0.1 Build version 9A1004
Android Studio: Not Found
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.3 => 0.55.3
Steps to Reproduce
Clone this repository and run it via
react-native run-ios
.Observe the section separators are in wrong (randomly?) places.
Expected Behavior
The section list headers should be in the top of the section instead of the bottom like section footers do with an inverted list (but they aren't sticky).
Expected gif:
Actual Behavior
The section headers are footers instead of headers. They are sticky because of #17762 but still footers, not headers.
Sample code:
Problem Gif:
The text was updated successfully, but these errors were encountered: