[Android] Unable to recreateReactContextInBackground #14533

sergey-akhalkov · 2017-06-15T10:18:49Z

Hey guys,

Description

There is an issue with recreateReactContextInBackground() method after upgrading React Native version from 0.44.3 to 0.45.1:

06-08 13:19:29.400  2262  2262 E AndroidRuntime: FATAL EXCEPTION: main
06-08 13:19:29.400  2262  2262 E AndroidRuntime: Process: com.testapp_rn, PID: 2262
06-08 13:19:29.400  2262  2262 E AndroidRuntime: com.facebook.react.uimanager.IllegalViewOperationException: Trying to add a root view with an explicit id already set. React Native uses the id field to track react tags and will overwrite this field. If that is fine, explicitly overwrite the id field to View.NO_ID before calling addMeasuredRootView.
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.uimanager.NativeViewHierarchyManager.addRootViewGroup(NativeViewHierarchyManager.java:504)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.uimanager.NativeViewHierarchyManager.addRootView(NativeViewHierarchyManager.java:496)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.uimanager.UIViewOperationQueue.addRootView(UIViewOperationQueue.java:570)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.uimanager.UIImplementation.registerRootView(UIImplementation.java:129)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.uimanager.UIManagerModule.addMeasuredRootView(UIManagerModule.java:210)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.ReactInstanceManager.attachMeasuredRootViewToInstance(ReactInstanceManager.java:861)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.ReactInstanceManager.setupReactContext(ReactInstanceManager.java:816)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.ReactInstanceManager.access$1100(ReactInstanceManager.java:109)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.facebook.react.ReactInstanceManager$4$2.run(ReactInstanceManager.java:771)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:739)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:95)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:148)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:5417)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
06-08 13:19:29.400  2262  2262 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
06-08 13:19:29.401   652   784 W ActivityManager:   Force finishing activity com.testapp_rn/.MainActivity
06-08 13:19:29.516   346   346 E EGL_emulation: tid 346: eglCreateSyncKHR(1215): error 0x3004 (EGL_BAD_ATTRIBUTE)

I have RN project that uses CodePush SDK and I want to call CodePush.restartApp method, but I'm receiving the error above.
To restart an app (reload js bundle) CodePush.restartApp method uses loadBundle method and loadBundle method uses recreateReactContextInBackground() to recreate context and load new js bundle:
restartApp -> loadBundle -> recreateReactContextInBackground

I'm expecting that react context will be recreated successfully without no errors.

Reproduction Steps

unzip archive that I've provided below
npm i
gradlew assembleDebug (I'm using bundleInDebug: true)
install apk
open app
click Restart App

Sample Code

Here is app sample. rncp210release.zip

Source code:

import CodePush from "react-native-code-push";
...
restartApp() {
    CodePush.restartApp(false);
}
...
<TouchableOpacity onPress={this.restartApp.bind(this)}>
    <Text style={styles.syncButton}>Restart App</Text>
</TouchableOpacity>

Additional Information

React Native version: 0.45.1
Platform: Android
Development Operating System: Windows
Build tools: Android Studio 2.3.1

The text was updated successfully, but these errors were encountered:

sergey-akhalkov · 2017-06-20T07:28:23Z

Hey guys, would you have a chance please to take a look at this? Let me know if you need more info or need any help.

ramsestom · 2017-06-21T01:54:11Z

Also have this issue, when runing in debug mode from Visual studio, since I ugrated a project from react native 0.41 to 0.45.1 . I don't know how to fix it...

yaronlevi · 2017-06-21T12:20:30Z

I can confirm that this issue also happens on a production app with the following details:

nexus 5 device
react [email protected]
code push with default setup (just wrapping the top component with codepush() )

When downloading a fresh app from the Play Store, it crashes a few seconds after the first run (probably because it's trying to do a restart like mentioned above).
In the crash reports I can also see the error:
"Trying to add a root view with an explicit id already set. React Native uses the id field to track react tags..."

(Interesting to see if it happens also on 0.45.0)

D1no · 2017-06-21T18:10:42Z

0.45.0 to .1 is only a small update of the packanger that was referencing a wrong path for the cli to pick up.

However, 0.45.x uses a slightly different way of handling the js in the delegate file.

Does this crash also appear in a fresh init project that has not been upgraded (re-producing)?
Even though the app crashes, is the update (after a manual restart) applied?

yaronlevi · 2017-06-21T21:12:08Z

@D1no I don't know about a fresh project. Need to check it.
I almost sure the update is applied, but need to check it again.

sergey-akhalkov · 2017-06-22T10:20:24Z

Hi @D1no, thank you for the assistance, please let me know if you need any help.

sergey-akhalkov · 2017-06-22T11:01:39Z

Hi @D1no, thanks for your help. I also should mention, that the issues reproduces for 0.45.x only and we have not seen such kind of issues before, another words - the issue does not reproduce for previous versions of RN (0.44.x, 0.43.x and so on).

sergey-akhalkov · 2017-06-23T09:38:29Z

Hey guys, I've figured out what goes wrong here - we need to perform the following commands on attached root views in instanceManager:

reactRootView.removeAllViews();
reactRootView.setId(View.NO_ID);

The details are here: https://github.com/Microsoft/react-native-code-push/pull/901/files#diff-99865b122cb5308ab005ac99ccb55da0R185

So could someone please tell me why those lines that fixes the exception has been removed from RN 0.45? - I'm going to create PR that will fix it in RN itself, but good to know what was wrong with those lines and why they have been removed.

andrepcg · 2017-06-23T11:27:03Z

Having this same crash as well. Will try the fix above.

Edit: it works

sergey-akhalkov · 2017-06-23T14:58:55Z

Hi @andrepcg, great! Thanks for the response, going to release version 3.0.0 of react-native-code-push on the next week.

D1no · 2017-06-23T19:56:20Z

Wow that was quick! Congrats!

yaronlevi · 2017-06-23T21:51:37Z

Thank you! We are eagerly waiting for it (:

ramsestom · 2017-06-26T15:58:30Z

Can we keep this issue open? Because it might be fixed in react-native-code-push but is is not in react-native in general where this issue remain....

sergey-akhalkov · 2017-06-26T18:11:25Z

Hi @ramsestom, sure, I've closed it by mistake, sorry for it.

sergey-akhalkov · 2017-06-28T14:23:13Z

Hey guys, as I can see - the fix I've implemented for react-native-code-push is currently in master branch here . And the previous version of RN 0.45.1 does not contain this changes. So the issue probably should be fixed in next versions of RN.

sergey-akhalkov · 2017-07-27T08:02:25Z

The issue has been fixed in c639a1f, closing this.

gentlee · 2018-02-28T05:07:57Z

Still have this issue:

com.facebook.react.uimanager.IllegalViewOperationException: Trying to add a root view with an explicit id already set. React Native uses the id field to track react tags and will overwrite this field. If that is fine, explicitly overwrite the id field to View.NO_ID before calling addRootView.
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.uimanager.NativeViewHierarchyManager.addRootViewGroup(NativeViewHierarchyManager.java:510)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.uimanager.NativeViewHierarchyManager.addRootView(NativeViewHierarchyManager.java:502)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIViewOperationQueue.addRootView(UIViewOperationQueue.java:605)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIImplementation.registerRootView(UIImplementation.java:211)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIManagerModule.addRootView(UIManagerModule.java:302)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.ReactInstanceManager.attachRootViewToInstance(ReactInstanceManager.java:1021)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.ReactInstanceManager.setupReactContext(ReactInstanceManager.java:978)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.ReactInstanceManager.access$1300(ReactInstanceManager.java:113)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.ReactInstanceManager$5$2.run(ReactInstanceManager.java:941)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at android.os.Handler.handleCallback(Handler.java:790)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at android.os.Handler.dispatchMessage(Handler.java:99)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at android.os.Looper.loop(Looper.java:164)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:194)
02-27 17:55:33.392 11588 11711 E unknown:ReactNative: 	at java.lang.Thread.run(Thread.java:764)

Using react-native-restart library that calls recreateReactContextInBackground, for changing app's language.

RN 0.53.3 (and 0.51.0)

UPDATE: This was probably because it was called multiple times, so fixed it by calling once. But still this is a bug.

sergey-akhalkov mentioned this issue Jun 15, 2017

React Native 0.45 support microsoft/react-native-code-push#878

Closed

yaronlevi mentioned this issue Jun 22, 2017

App crash when trying to do CodePush.restartApp in [email protected] microsoft/code-push#482

Closed

sergey-akhalkov mentioned this issue Jun 22, 2017

add support for RN 0.45.x microsoft/react-native-code-push#901

Merged

sergey-akhalkov closed this as completed in microsoft/react-native-code-push#901 Jun 26, 2017

sergey-akhalkov reopened this Jun 26, 2017

AndrewJack mentioned this issue Jun 28, 2017

[0.46] Commits to cherry-pick #14713

Closed

sergey-akhalkov closed this as completed Jul 27, 2017

AndrewJack mentioned this issue Aug 31, 2017

Android crash with InstallMode.IMMEDIATE - IllegalViewOperationException: Trying to remove a view index above child count microsoft/react-native-code-push#986

Closed

facebook locked as resolved and limited conversation to collaborators Jul 27, 2018

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Unable to recreateReactContextInBackground #14533

[Android] Unable to recreateReactContextInBackground #14533

sergey-akhalkov commented Jun 15, 2017 •

edited

Loading

sergey-akhalkov commented Jun 20, 2017 •

edited

Loading

ramsestom commented Jun 21, 2017 •

edited

Loading

yaronlevi commented Jun 21, 2017 •

edited

Loading

D1no commented Jun 21, 2017

yaronlevi commented Jun 21, 2017

sergey-akhalkov commented Jun 22, 2017

sergey-akhalkov commented Jun 22, 2017 •

edited

Loading

sergey-akhalkov commented Jun 23, 2017

andrepcg commented Jun 23, 2017 •

edited

Loading

sergey-akhalkov commented Jun 23, 2017

D1no commented Jun 23, 2017

yaronlevi commented Jun 23, 2017

ramsestom commented Jun 26, 2017

sergey-akhalkov commented Jun 26, 2017 •

edited

Loading

sergey-akhalkov commented Jun 28, 2017

sergey-akhalkov commented Jul 27, 2017

gentlee commented Feb 28, 2018 •

edited

Loading

[Android] Unable to recreateReactContextInBackground #14533

[Android] Unable to recreateReactContextInBackground #14533

Comments

sergey-akhalkov commented Jun 15, 2017 • edited Loading

Description

Reproduction Steps

Sample Code

Additional Information

sergey-akhalkov commented Jun 20, 2017 • edited Loading

ramsestom commented Jun 21, 2017 • edited Loading

yaronlevi commented Jun 21, 2017 • edited Loading

D1no commented Jun 21, 2017

yaronlevi commented Jun 21, 2017

sergey-akhalkov commented Jun 22, 2017

sergey-akhalkov commented Jun 22, 2017 • edited Loading

sergey-akhalkov commented Jun 23, 2017

andrepcg commented Jun 23, 2017 • edited Loading

sergey-akhalkov commented Jun 23, 2017

D1no commented Jun 23, 2017

yaronlevi commented Jun 23, 2017

ramsestom commented Jun 26, 2017

sergey-akhalkov commented Jun 26, 2017 • edited Loading

sergey-akhalkov commented Jun 28, 2017

sergey-akhalkov commented Jul 27, 2017

gentlee commented Feb 28, 2018 • edited Loading

sergey-akhalkov commented Jun 15, 2017 •

edited

Loading

sergey-akhalkov commented Jun 20, 2017 •

edited

Loading

ramsestom commented Jun 21, 2017 •

edited

Loading

yaronlevi commented Jun 21, 2017 •

edited

Loading

sergey-akhalkov commented Jun 22, 2017 •

edited

Loading

andrepcg commented Jun 23, 2017 •

edited

Loading

sergey-akhalkov commented Jun 26, 2017 •

edited

Loading

gentlee commented Feb 28, 2018 •

edited

Loading