-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left, Right, Top and Bottom with percentages don't work when same element has flexDirection: 'row' #12660
Comments
Summary: Adds support for percentage value in react native. syntax: property: 100 | property | '100%' supported properties: padding margin width height minWidth minHeight maxWidth maxHeight flexBasis ``` class Playground extends React.Component { render() { return ( <View style={{backgroundColor: 'white', padding: 10, paddingTop: 30, height: '100%'}}> <Text> If you want to quickly test out something, open the Playground.js file and start coding. </Text> <View style={{backgroundColor: 'red', height: 50, width: 50}}/> <View style={{backgroundColor: 'blue', height: '50%', width: '50%'}}/> </View> ); } } ``` Reviewed By: astreet Differential Revision: D4376549 fbshipit-source-id: c41d68a7555396f95d063a7527ee081773ac56dc
Can you please open this in the facebook/yoga repo instead? |
@emilsjolander I have posted this on facebook/yoga now :) facebook/yoga#454 |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Description
Here is example:
With this code the layout should look something like this:
Instead it looks like this:
So the
left
is not calculated right when the same element hasflexDirection: 'row'
This same happened also when using
left
,right
,bottom
andtop
properties.Reproduction
Run the code above by yourself. Also you can see how the same should look in the web: https://jsfiddle.net/L8ps52sp/3/
Solution
I think @emilsjolander should check this out since he added percentages in latest version ;)
Additional Information
The text was updated successfully, but these errors were encountered: