Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.42.0] Undesirable changes in Info.plist #12640

Closed
ncuillery opened this issue Mar 1, 2017 · 2 comments · May be fixed by hixio-mh/react-native#19
Closed

[0.42.0] Undesirable changes in Info.plist #12640

ncuillery opened this issue Mar 1, 2017 · 2 comments · May be fixed by hixio-mh/react-native#19
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ncuillery
Copy link
Contributor

ncuillery commented Mar 1, 2017

When upgrading from 0.41.2 to 0.42.0 (using either react-native upgrade or react-native-git-upgrade), two lines are removed in the Info.plist file:

ncuillery/rn-diff@rn-0.41.2...rn-0.42.0#diff-faf314fabd1fcf63d4c5d4dc90ac7f1c

I think that's because this commit 516d973 is in the 0.41-stable but has not been cherry-picked in the 0.42-stable. This commit has changed the HelloWorld template used by the upgrade tools.

@felipemsantana
Copy link
Contributor

I was going to create an issue for this, the CLI command eject is not working anymore.

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants