Commit cd43de6
Fix android root view group removal during instance re-creation (#41678)
Summary:
This is my proposed solution to #41677.
Fixes #41677.
## Changelog:
[ANDROID] [FIXED] - Fix android root view group removal during instance re-creation
Pull Request resolved: #41678
Test Plan:
Both with fabric enabled and disabled (new architecture):
1. Clone repro repo: https://github.com/wschurman/rn-reload-repro
2. Build and run on android (I use android studio)
3. Click reload button, see timestamp doesn't change (indicating that the view is not removed)
4. Apply this PR as a patch.
5. Re-build and run.
6. Click reload button, see view is correctly disposed of and the new view is set.
Reviewed By: cortinico
Differential Revision: D51658524
Pulled By: javache
fbshipit-source-id: d9a026cde677ad1ec113230bc31bd9297bca8bfc1 parent 0d5e678 commit cd43de6
File tree
1 file changed
+1
-4
lines changed- packages/react-native/ReactAndroid/src/main/java/com/facebook/react
1 file changed
+1
-4
lines changedLines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1278 | 1278 | | |
1279 | 1279 | | |
1280 | 1280 | | |
1281 | | - | |
1282 | 1281 | | |
1283 | 1282 | | |
1284 | 1283 | | |
1285 | 1284 | | |
1286 | 1285 | | |
1287 | 1286 | | |
1288 | | - | |
1289 | 1287 | | |
1290 | 1288 | | |
1291 | 1289 | | |
| |||
1294 | 1292 | | |
1295 | 1293 | | |
1296 | 1294 | | |
1297 | | - | |
1298 | | - | |
| 1295 | + | |
1299 | 1296 | | |
1300 | 1297 | | |
1301 | 1298 | | |
| |||
0 commit comments