From c5d380fc98ff4417f623effec271d24f9ad6636d Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Wed, 12 Jun 2024 10:14:48 -0700 Subject: [PATCH] Avoid static_pointer_cast in GenerateModuleH.js (#44889) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44889 Avoid static_pointer_cast. It provides no type-safety, and requires increasing the shared_ptr ## Changelog: [Internal] [Fixed] - Avoid static_pointer_cast in GenerateModuleH.js Reviewed By: javache Differential Revision: D58449748 fbshipit-source-id: 4d46b4e18fc28758296a67271182a471a99b5d83 --- .../src/generators/modules/GenerateModuleH.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js b/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js index 66ccda7e4d6c1e..9c7a69c510d370 100644 --- a/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js +++ b/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js @@ -568,9 +568,9 @@ function translateEventEmitterToCpp( isArray ? `std::vector<${templateName}>` : templateName }, ${jsiType}>, "value cannnot be converted to ${jsiType}");` } - std::static_pointer_cast>(delegate_.eventEmitterMap_["${eventEmitter.name}"])->emit(${ + }>&>(*delegate_.eventEmitterMap_["${eventEmitter.name}"]).emit(${ isVoidTypeAnnotation ? '' : `[jsInvoker = jsInvoker_, eventValue = value](jsi::Runtime& rt) -> jsi::Value {