Skip to content

Commit c54aecc

Browse files
Huxprofacebook-github-bot
authored andcommitted
Reflect Hermes release version from HermesBadge
Summary: Changelog: [General] - Reflect Hermes release version from HermesBadge It was a common footgun that an unexpected version of Hermes engine is used in a RN app. To help with indicating this from the runtime, Hermes exposes its OSS release version from `HermesInternal.getRuntimeProperties()` Starting from 0.8.0. This diff updates the `HermesBadge` used by `NewAppScreen` header to reflect the version. Reviewed By: nadiia Differential Revision: D24436609 fbshipit-source-id: 8ba45be598a7d5af0e38f5044f9370fc7e1eb9a1
1 parent 9e020ef commit c54aecc

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Libraries/NewAppScreen/components/HermesBadge.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ import Colors from './Colors';
1515

1616
const HermesBadge = (): Node => {
1717
const isDarkMode = useColorScheme() === 'dark';
18+
const version =
19+
global.HermesInternal?.getRuntimeProperties?.()['OSS Release Version'] ??
20+
'';
1821
return global.HermesInternal ? (
1922
<View style={styles.badge}>
2023
<Text
@@ -24,7 +27,7 @@ const HermesBadge = (): Node => {
2427
color: isDarkMode ? Colors.light : Colors.dark,
2528
},
2629
]}>
27-
Engine: Hermes
30+
{`Engine: Hermes ${version}`}
2831
</Text>
2932
</View>
3033
) : null;

0 commit comments

Comments
 (0)