Reset sMatrixDecompositionContext before applying transformations

makovkastar · facebook-github-bot · commit bf01dfbc97ea · 2019-09-04T09:47:56.000-07:00
Summary: Recover accidentally removed call to `sMatrixDecompositionContext.reset()` added in #25438. Reviewed By: mdvacca Differential Revision: D17136023 fbshipit-source-id: 01d351729b427a01a04e3a260f72c12da7b8d03a
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
@@ -287,6 +287,7 @@ public void setAccessibilityLiveRegion(@NonNull T view, @Nullable String liveReg
   }
 
   private static void setTransformProperty(@NonNull View view, ReadableArray transforms) {
+    sMatrixDecompositionContext.reset();
     TransformHelper.processTransform(transforms, sTransformDecompositionArray);
     MatrixMathHelper.decomposeMatrix(sTransformDecompositionArray, sMatrixDecompositionContext);
     view.setTranslationX(

Original file line number	Diff line number	Diff line change
`@@ -287,6 +287,7 @@ public void setAccessibilityLiveRegion(@NonNull T view, @Nullable String liveReg`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`private static void setTransformProperty(@NonNull View view, ReadableArray transforms) {`
	`290`	`+ sMatrixDecompositionContext.reset();`
`290`	`291`	`TransformHelper.processTransform(transforms, sTransformDecompositionArray);`
`291`	`292`	`MatrixMathHelper.decomposeMatrix(sTransformDecompositionArray, sMatrixDecompositionContext);`
`292`	`293`	`view.setTranslationX(`