Moving towards UIWindowScene support (#28058)

Summary:
Pull Request resolved: #28058

I'm taking the first step towards supporting iOS 13 UIScene APIs and modernizing React Native not to assume an app only has a single window. See discussion here: #25181 (comment)

The approach I'm taking is to take advantage of `RootTagContext` and passing it to NativeModules so that they can identify correctly which window they refer to. Here I'm just laying groundwork.

- [x] `Alert` and `ActionSheetIOS` take an optional `rootTag` argument that will cause them to appear on the correct window
- [x] `StatusBar` methods also have `rootTag` argument added, but it's not fully hooked up on the native side — this turns out to require some more work, see: #25181 (comment)
- [x] `setNetworkActivityIndicatorVisible` is deprecated in iOS 13
- [x] `RCTPerfMonitor`, `RCTProfile` no longer assume `UIApplicationDelegate` has a `window` property (no longer the best practice) — they now just render on the key window

Next steps: Add VC-based status bar management (if I get the OK on #25181 (comment) ), add multiple window demo to RNTester, deprecate Dimensions in favor of a layout context, consider adding hook-based APIs for native modules such as Alert that automatically know which rootTag to pass

## Changelog

[Internal] [Changed] - Modernize Modal to use RootTagContext
[iOS] [Changed] - `Alert`, `ActionSheetIOS`, `StatusBar` methods now take an optional `surface` argument (for future iPadOS 13 support)
[iOS] [Changed] - RCTPresentedViewController now takes a nullable `window` arg
[Internal] [Changed] - Do not assume `UIApplicationDelegate` has a `window` property
Pull Request resolved: #25425

Test Plan:
- Open RNTester and:
- go to Modal and check if it still works
- Alert → see if works
- ACtionSheetIOS → see if it works
- StatusBar → see if it works
- Share → see if it works

Reviewed By: PeteTheHeat

Differential Revision: D16957751

Pulled By: hramos

fbshipit-source-id: ae2a4478e2e7f8d2be3022c9c4861561ec244a26

Author: radex

Libraries/ActionSheetIOS/ActionSheetIOS.js

@@ -11,6 +11,7 @@
 'use strict';
 
 import RCTActionSheetManager from './NativeActionSheetManager';
+import ReactNative from '../Renderer/shims/ReactNative';
 
 const invariant = require('invariant');
 const processColor = require('../StyleSheet/processColor');
@@ -43,12 +44,13 @@ const ActionSheetIOS = {
     options: {|
       +title?: ?string,
       +message?: ?string,
-      +options: Array<string>,
+      +options: ?Array<string>,
       +destructiveButtonIndex?: ?number | ?Array<number>,
       +cancelButtonIndex?: ?number,
       +anchor?: ?number,
       +tintColor?: ColorValue | ProcessedColorValue,
       +userInterfaceStyle?: string,
+      +surface?: mixed,
     |},
     callback: (buttonIndex: number) => void,
   ) {
@@ -59,7 +61,13 @@ const ActionSheetIOS = {
     invariant(typeof callback === 'function', 'Must provide a valid callback');
     invariant(RCTActionSheetManager, "ActionSheetManager does't exist");
 
-    const {tintColor, destructiveButtonIndex, ...remainingOptions} = options;
+    const {
+      tintColor,
+      destructiveButtonIndex,
+      surface,
+      ...remainingOptions
+    } = options;
+    const reactTag = ReactNative.findNodeHandle(surface) ?? -1;
     let destructiveButtonIndices = null;
 
     if (Array.isArray(destructiveButtonIndex)) {
@@ -76,6 +84,7 @@ const ActionSheetIOS = {
     RCTActionSheetManager.showActionSheetWithOptions(
       {
         ...remainingOptions,
+        reactTag,
         tintColor: processedTintColor,
         destructiveButtonIndices,
       },
@@ -124,8 +133,16 @@ const ActionSheetIOS = {
       'Must provide a valid successCallback',
     );
     invariant(RCTActionSheetManager, "ActionSheetManager does't exist");
+
+    const {tintColor, surface, ...remainingOptions} = options;
+    const reactTag = ReactNative.findNodeHandle(surface) ?? -1;
+
     RCTActionSheetManager.showShareActionSheetWithOptions(
-      {...options, tintColor: processColor(options.tintColor)},
+      {
+        ...remainingOptions,
+        reactTag,
+        tintColor: processColor(options.tintColor),
+      },
       failureCallback,
       successCallback,
     );

Libraries/ActionSheetIOS/NativeActionSheetManager.js

@@ -25,6 +25,7 @@ export interface Spec extends TurboModule {
       +anchor?: ?number,
       +tintColor?: ?number,
       +userInterfaceStyle?: ?string,
+      +reactTag?: number,
     |},
     callback: (buttonIndex: number) => void,
   ) => void;
@@ -37,6 +38,7 @@ export interface Spec extends TurboModule {
       +tintColor?: ?number,
       +excludedActivityTypes?: ?Array<string>,
       +userInterfaceStyle?: ?string,
+      +reactTag?: number,
     |},
     failureCallback: (error: {|
       +domain: string,

Libraries/Alert/Alert.js

@@ -15,6 +15,7 @@ import NativeDialogManagerAndroid, {
   type DialogOptions,
 } from '../NativeModules/specs/NativeDialogManagerAndroid';
 import RCTAlertManager from './RCTAlertManager';
+import ReactNative from '../Renderer/shims/ReactNative';
 
 export type AlertType =
   | 'default'
@@ -32,9 +33,14 @@ export type Buttons = Array<{
 type Options = {
   cancelable?: ?boolean,
   onDismiss?: ?() => void,
+  surface?: mixed,
   ...
 };
 
+type PromptOptions = {
+  surface?: mixed,
+};
+
 /**
  * Launches an alert dialog with the specified title and message.
  *
@@ -45,10 +51,12 @@ class Alert {
     title: ?string,
     message?: ?string,
     buttons?: Buttons,
-    options?: Options,
+    options?: Options = {},
   ): void {
     if (Platform.OS === 'ios') {
-      Alert.prompt(title, message, buttons, 'default');
+      Alert.prompt(title, message, buttons, 'default', undefined, undefined, {
+        surface: options.surface,
+      });
     } else if (Platform.OS === 'android') {
       if (!NativeDialogManagerAndroid) {
         return;
@@ -61,7 +69,7 @@ class Alert {
         cancelable: false,
       };
 
-      if (options && options.cancelable) {
+      if (options.cancelable) {
         config.cancelable = options.cancelable;
       }
       // At most three buttons (neutral, negative, positive). Ignore rest.
@@ -94,7 +102,7 @@ class Alert {
             buttonPositive.onPress && buttonPositive.onPress();
           }
         } else if (action === constants.dismissed) {
-          options && options.onDismiss && options.onDismiss();
+          options.onDismiss && options.onDismiss();
         }
       };
       const onError = errorMessage => console.warn(errorMessage);
@@ -109,6 +117,7 @@ class Alert {
     type?: ?AlertType = 'plain-text',
     defaultValue?: string,
     keyboardType?: string,
+    options?: PromptOptions = {surface: undefined},
   ): void {
     if (Platform.OS === 'ios') {
       let callbacks = [];
@@ -143,6 +152,7 @@ class Alert {
           cancelButtonKey,
           destructiveButtonKey,
           keyboardType,
+          reactTag: ReactNative.findNodeHandle(options.surface) ?? -1,
         },
         (id, value) => {
           const cb = callbacks[id];

Libraries/Alert/NativeAlertManager.js

@@ -22,6 +22,7 @@ export type Args = {|
   cancelButtonKey?: string,
   destructiveButtonKey?: string,
   keyboardType?: string,
+  reactTag?: number,
 |};
 
 export interface Spec extends TurboModule {

Libraries/CameraRoll/RCTImagePickerManager.mm

@@ -204,7 +204,7 @@ - (void)_presentPicker:(UIImagePickerController *)imagePicker
   [_pickerCallbacks addObject:callback];
   [_pickerCancelCallbacks addObject:cancelCallback];
 
-  UIViewController *rootViewController = RCTPresentedViewController();
+  UIViewController *rootViewController = RCTPresentedViewController(nil);
   [rootViewController presentViewController:imagePicker animated:YES completion:nil];
 }
 
@@ -223,7 +223,7 @@ - (void)_dismissPicker:(UIImagePickerController *)picker args:(NSArray *)args
   [_pickerCallbacks removeObjectAtIndex:index];
   [_pickerCancelCallbacks removeObjectAtIndex:index];
 
-  UIViewController *rootViewController = RCTPresentedViewController();
+  UIViewController *rootViewController = RCTPresentedViewController(nil);
   [rootViewController dismissViewControllerAnimated:YES completion:nil];
 
   if (args) {

Libraries/Components/StatusBar/NativeStatusBarManagerIOS.js

@@ -31,11 +31,19 @@ export interface Spec extends TurboModule {
    *    - 'dark-content'
    *    - 'light-content'
    */
-  +setStyle: (statusBarStyle?: ?string, animated: boolean) => void;
+  +setStyle: (
+    statusBarStyle?: ?string,
+    animated: boolean,
+    reactTag?: number,
+  ) => void;
   /**
    *  - withAnimation can be: 'none' | 'fade' | 'slide'
    */
-  +setHidden: (hidden: boolean, withAnimation: string) => void;
+  +setHidden: (
+    hidden: boolean,
+    withAnimation: string,
+    reactTag?: number,
+  ) => void;
 }
 
 export default (TurboModuleRegistry.getEnforcing<Spec>(

Libraries/Components/StatusBar/StatusBar.js

@@ -11,6 +11,8 @@
 'use strict';
 
 const Platform = require('../../Utilities/Platform');
+const RootTagContext = require('../../ReactNative/RootTagContext');
+import ReactNative from '../../Renderer/shims/ReactNative';
 const React = require('react');
 
 const invariant = require('invariant');
@@ -264,11 +266,19 @@ class StatusBar extends React.Component<Props> {
    * @param animation Optional animation when
    *    changing the status bar hidden property.
    */
-  static setHidden(hidden: boolean, animation?: StatusBarAnimation) {
+  static setHidden(
+    hidden: boolean,
+    animation?: StatusBarAnimation,
+    surface?: mixed,
+  ) {
     animation = animation || 'none';
     StatusBar._defaultProps.hidden.value = hidden;
     if (Platform.OS === 'ios') {
-      NativeStatusBarManagerIOS.setHidden(hidden, animation);
+      NativeStatusBarManagerIOS.setHidden(
+        hidden,
+        animation,
+        ReactNative.findNodeHandle(surface) ?? -1,
+      );
     } else if (Platform.OS === 'android') {
       NativeStatusBarManagerAndroid.setHidden(hidden);
     }
@@ -279,11 +289,19 @@ class StatusBar extends React.Component<Props> {
    * @param style Status bar style to set
    * @param animated Animate the style change.
    */
-  static setBarStyle(style: StatusBarStyle, animated?: boolean) {
+  static setBarStyle(
+    style: StatusBarStyle,
+    animated?: boolean,
+    surface?: mixed,
+  ) {
     animated = animated || false;
     StatusBar._defaultProps.barStyle.value = style;
     if (Platform.OS === 'ios') {
-      NativeStatusBarManagerIOS.setStyle(style, animated);
+      NativeStatusBarManagerIOS.setStyle(
+        style,
+        animated,
+        ReactNative.findNodeHandle(surface) ?? -1,
+      );
     } else if (Platform.OS === 'android') {
       NativeStatusBarManagerAndroid.setStyle(style);
     }
@@ -292,6 +310,7 @@ class StatusBar extends React.Component<Props> {
   /**
    * Control the visibility of the network activity indicator
    * @param visible Show the indicator.
+   * @platform ios
    */
   static setNetworkActivityIndicatorVisible(visible: boolean) {
     if (Platform.OS !== 'ios') {
@@ -308,6 +327,7 @@ class StatusBar extends React.Component<Props> {
    * Set the background color for the status bar
    * @param color Background color.
    * @param animated Animate the style change.
+   * @platform android
    */
   static setBackgroundColor(color: string, animated?: boolean) {
     if (Platform.OS !== 'android') {
@@ -335,6 +355,7 @@ class StatusBar extends React.Component<Props> {
   /**
    * Control the translucency of the status bar
    * @param translucent Set as translucent.
+   * @platform android
    */
   static setTranslucent(translucent: boolean) {
     if (Platform.OS !== 'android') {
@@ -351,10 +372,10 @@ class StatusBar extends React.Component<Props> {
    *
    * @param props Object containing the StatusBar props to use in the stack entry.
    */
-  static pushStackEntry(props: any): any {
+  static pushStackEntry(props: any, surface?: mixed): any {
     const entry = createStackEntry(props);
     StatusBar._propsStack.push(entry);
-    StatusBar._updatePropsStack();
+    StatusBar._updatePropsStack(surface);
     return entry;
   }
 
@@ -363,12 +384,12 @@ class StatusBar extends React.Component<Props> {
    *
    * @param entry Entry returned from `pushStackEntry`.
    */
-  static popStackEntry(entry: any) {
+  static popStackEntry(entry: any, surface?: mixed) {
     const index = StatusBar._propsStack.indexOf(entry);
     if (index !== -1) {
       StatusBar._propsStack.splice(index, 1);
     }
-    StatusBar._updatePropsStack();
+    StatusBar._updatePropsStack(surface);
   }
 
   /**
@@ -377,13 +398,13 @@ class StatusBar extends React.Component<Props> {
    * @param entry Entry returned from `pushStackEntry` to replace.
    * @param props Object containing the StatusBar props to use in the replacement stack entry.
    */
-  static replaceStackEntry(entry: any, props: any): any {
+  static replaceStackEntry(entry: any, props: any, surface?: mixed): any {
     const newEntry = createStackEntry(props);
     const index = StatusBar._propsStack.indexOf(entry);
     if (index !== -1) {
       StatusBar._propsStack[index] = newEntry;
     }
-    StatusBar._updatePropsStack();
+    StatusBar._updatePropsStack(surface);
     return newEntry;
   }
 
@@ -395,33 +416,37 @@ class StatusBar extends React.Component<Props> {
     showHideTransition: 'fade',
   };
 
+  // $FlowFixMe (signature-verification-failure)
+  static contextType = RootTagContext;
+
   _stackEntry = null;
 
   componentDidMount() {
     // Every time a StatusBar component is mounted, we push it's prop to a stack
     // and always update the native status bar with the props from the top of then
     // stack. This allows having multiple StatusBar components and the one that is
     // added last or is deeper in the view hierarchy will have priority.
-    this._stackEntry = StatusBar.pushStackEntry(this.props);
+    this._stackEntry = StatusBar.pushStackEntry(this.props, this.context);
   }
 
   componentWillUnmount() {
     // When a StatusBar is unmounted, remove itself from the stack and update
     // the native bar with the next props.
-    StatusBar.popStackEntry(this._stackEntry);
+    StatusBar.popStackEntry(this._stackEntry, this.context);
   }
 
   componentDidUpdate() {
     this._stackEntry = StatusBar.replaceStackEntry(
       this._stackEntry,
       this.props,
+      this.context,
     );
   }
 
   /**
    * Updates the native status bar with the props from the stack.
    */
-  static _updatePropsStack = () => {
+  static _updatePropsStack = (surface?: mixed) => {
     // Send the update to the native module only once at the end of the frame.
     clearImmediate(StatusBar._updateImmediate);
     StatusBar._updateImmediate = setImmediate(() => {
@@ -440,6 +465,7 @@ class StatusBar extends React.Component<Props> {
           NativeStatusBarManagerIOS.setStyle(
             mergedProps.barStyle.value,
             mergedProps.barStyle.animated || false,
+            ReactNative.findNodeHandle(surface) ?? -1,
           );
         }
         if (!oldProps || oldProps.hidden.value !== mergedProps.hidden.value) {
@@ -448,6 +474,7 @@ class StatusBar extends React.Component<Props> {
             mergedProps.hidden.animated
               ? mergedProps.hidden.transition
               : 'none',
+            ReactNative.findNodeHandle(surface) ?? -1,
           );
         }