Skip to content

Commit b496a53

Browse files
robertyingfacebook-github-bot
authored andcommitted
Fix cli bundle platform for Mac Catalyst in react-native-xcode.sh (#31062)
Summary: A recent commit 941bc0e#diff-0eeea47fa4bace26fa6c492a03fa0ea3923a2d8d54b7894f7760cb9131ab65eb on Hermes macOS brings a regression for Mac Catalyst target. Once hardcoded cli bundle platform `ios` can now be either `ios` or `macos`. However, Mac Catalyst is identified as `macos` rather than `ios`. This PR should fix it and close #31061. ## Changelog [iOS] [Fixed] - Fix cli bundle platform for Mac Catalyst in `react-native-xcode.sh` Pull Request resolved: #31062 Test Plan: 1. Build fails on a new RN 0.64-rc.3 project. 2. Apply the fix. 3. Build passes. Reviewed By: TheSavior Differential Revision: D29038793 Pulled By: appden fbshipit-source-id: 29761f887ec7a9cc26f088953c3888c6d19bed71
1 parent c714a80 commit b496a53

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

scripts/react-native-xcode.sh

+4
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,10 @@ case "$PLATFORM_NAME" in
128128
;;
129129
esac
130130

131+
if [ "${IS_MACCATALYST}" = "YES" ]; then
132+
BUNDLE_PLATFORM="ios"
133+
fi
134+
131135
EMIT_SOURCEMAP=
132136
if [[ ! -z "$SOURCEMAP_FILE" ]]; then
133137
EMIT_SOURCEMAP=true

0 commit comments

Comments
 (0)