From b44e3f69a41b6b13ba7be992289090f90dac0265 Mon Sep 17 00:00:00 2001 From: Gijs Weterings Date: Wed, 12 Jun 2024 11:48:07 -0700 Subject: [PATCH] Add java and JS coverage collection to RNTester for Jest E2E (#44856) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44856 Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D58360098 fbshipit-source-id: dd06f9d3f2fe887cb9311ccfef811a2965ca5750 --- ...dToEndDumpsysHelper.kt => FBRNTesterEndToEndHelper.kt} | 8 +++++++- .../java/com/facebook/react/uiapp/RNTesterActivity.kt | 6 +++--- 2 files changed, 10 insertions(+), 4 deletions(-) rename packages/rn-tester/android/app/src/main/java/com/facebook/react/{FBEndToEndDumpsysHelper.kt => FBRNTesterEndToEndHelper.kt} (65%) diff --git a/packages/rn-tester/android/app/src/main/java/com/facebook/react/FBEndToEndDumpsysHelper.kt b/packages/rn-tester/android/app/src/main/java/com/facebook/react/FBRNTesterEndToEndHelper.kt similarity index 65% rename from packages/rn-tester/android/app/src/main/java/com/facebook/react/FBEndToEndDumpsysHelper.kt rename to packages/rn-tester/android/app/src/main/java/com/facebook/react/FBRNTesterEndToEndHelper.kt index d5ba25052210c7..81a490aaee2093 100644 --- a/packages/rn-tester/android/app/src/main/java/com/facebook/react/FBEndToEndDumpsysHelper.kt +++ b/packages/rn-tester/android/app/src/main/java/com/facebook/react/FBRNTesterEndToEndHelper.kt @@ -7,9 +7,15 @@ package com.facebook.react +import android.app.Application import java.io.PrintWriter -object FBEndToEndDumpsysHelper { +object FBRNTesterEndToEndHelper { + fun onCreate(application: Application) { + // no-op This is an empty implementation to stub out Meta's internal test coverage + // instrumentation. + } + fun maybeDump(prefix: String, writer: PrintWriter, args: Array?) { // no-op This is an empty implementation to stub out Meta's internal dumpsys helper. } diff --git a/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt b/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt index 1b954ed1efe243..3777c2b81ee75c 100644 --- a/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt +++ b/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt @@ -8,7 +8,7 @@ package com.facebook.react.uiapp import android.os.Bundle -import com.facebook.react.FBEndToEndDumpsysHelper +import com.facebook.react.FBRNTesterEndToEndHelper import com.facebook.react.ReactActivity import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.fabricEnabled import com.facebook.react.defaults.DefaultReactActivityDelegate @@ -29,7 +29,7 @@ class RNTesterActivity : ReactActivity() { val routeUri = "rntester://example/${bundle.getString(PARAM_ROUTE)}Example" initialProps = Bundle().apply { putString("exampleFromAppetizeParams", routeUri) } } - + FBRNTesterEndToEndHelper.onCreate(activity.application) super.onCreate(savedInstanceState) } @@ -47,6 +47,6 @@ class RNTesterActivity : ReactActivity() { writer: PrintWriter, args: Array? ) { - FBEndToEndDumpsysHelper.maybeDump(prefix, writer, args) + FBRNTesterEndToEndHelper.maybeDump(prefix, writer, args) } }