Fix View translations in Android

dgladkov · facebook-github-bot-9 · commit b12117a03847 · 2015-11-09T00:02:19.000-08:00
Summary: Fixes regression in bf59864 Closes #3773 Closes #3954 Reviewed By: svcscm Differential Revision: D2631180 Pulled By: kmagiera fb-gh-sync-id: 09a1a2e48fd6fff37d1491c120a28221cdc1b163
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
@@ -115,13 +115,13 @@ public void setScaleY(T view, float scaleY) {
   @Deprecated
   @ReactProp(name = PROP_TRANSLATE_X, defaultFloat = 1f)
   public void setTranslateX(T view, float translateX) {
-    view.setTranslationX(translateX);
+    view.setTranslationX(PixelUtil.toPixelFromDIP(translateX));
   }
 
   @Deprecated
   @ReactProp(name = PROP_TRANSLATE_Y, defaultFloat = 1f)
   public void setTranslateY(T view, float translateY) {
-    view.setTranslationY(translateY);
+    view.setTranslationY(PixelUtil.toPixelFromDIP(translateY));
   }
 
   @ReactProp(name = PROP_ACCESSIBILITY_LIVE_REGION)

Original file line number	Diff line number	Diff line change
`@@ -115,13 +115,13 @@ public void setScaleY(T view, float scaleY) {`
`115`	`115`	`@Deprecated`
`116`	`116`	`@ReactProp(name = PROP_TRANSLATE_X, defaultFloat = 1f)`
`117`	`117`	`public void setTranslateX(T view, float translateX) {`
`118`		`- view.setTranslationX(translateX);`
	`118`	`+ view.setTranslationX(PixelUtil.toPixelFromDIP(translateX));`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`@Deprecated`
`122`	`122`	`@ReactProp(name = PROP_TRANSLATE_Y, defaultFloat = 1f)`
`123`	`123`	`public void setTranslateY(T view, float translateY) {`
`124`		`- view.setTranslationY(translateY);`
	`124`	`+ view.setTranslationY(PixelUtil.toPixelFromDIP(translateY));`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`@ReactProp(name = PROP_ACCESSIBILITY_LIVE_REGION)`