Skip to content

Commit af9225e

Browse files
authored
Let's not build reactnativeutilsjni shared library (#34345)
Co-authored-by: Sparsha Saha
1 parent 4555fc7 commit af9225e

File tree

7 files changed

+6
-66
lines changed

7 files changed

+6
-66
lines changed

ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ LOCAL_SHARED_LIBRARIES := \
4040
libreact_render_uimanager \
4141
libreact_utils \
4242
libreact_config \
43-
libreactnativeutilsjni \
43+
libreactnativejni \
4444
librrc_image \
4545
librrc_root \
4646
librrc_unimplementedview \

ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
1919

2020
LOCAL_CFLAGS += -fexceptions -frtti -std=c++17 -Wall
2121

22-
LOCAL_SHARED_LIBRARIES = libfb libfbjni libreactnativeutilsjni libruntimeexecutor
22+
LOCAL_SHARED_LIBRARIES = libfb libfbjni libreactnativejni libruntimeexecutor
2323

2424
LOCAL_STATIC_LIBRARIES = libcallinvoker libreactperfloggerjni
2525

ReactAndroid/src/main/jni/react/jni/Android.mk

-60
Original file line numberDiff line numberDiff line change
@@ -3,67 +3,8 @@
33
# This source code is licensed under the MIT license found in the
44
# LICENSE file in the root directory of this source tree.
55

6-
7-
##########################
8-
### React Native Utils ###
9-
##########################
10-
116
LOCAL_PATH := $(call my-dir)
127

13-
include $(CLEAR_VARS)
14-
15-
# Include . in the header search path for all source files in this module.
16-
LOCAL_C_INCLUDES := $(LOCAL_PATH)
17-
18-
# Include ./../../ in the header search path for modules that depend on
19-
# reactnativejni. This will allow external modules to require this module's
20-
# headers using #include <react/jni/<header>.h>, assuming:
21-
# . == jni
22-
# ./../ == react
23-
LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)/../..
24-
25-
LOCAL_CFLAGS += -fexceptions -frtti -Wno-unused-lambda-capture
26-
27-
LOCAL_LDLIBS += -landroid
28-
29-
# The dynamic libraries (.so files) that this module depends on.
30-
LOCAL_SHARED_LIBRARIES := \
31-
libfb \
32-
libfbjni \
33-
libfolly_json \
34-
libglog_init \
35-
libreact_render_runtimescheduler \
36-
libruntimeexecutor \
37-
libyoga
38-
39-
# The static libraries (.a files) that this module depends on.
40-
LOCAL_STATIC_LIBRARIES := libreactnative libcallinvokerholder
41-
42-
# Name of this module.
43-
#
44-
# Other modules can depend on this one by adding libreactnativejni to their
45-
# LOCAL_SHARED_LIBRARIES variable.
46-
LOCAL_MODULE := reactnativeutilsjni
47-
48-
# Compile all local c++ files.
49-
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
50-
LOCAL_SRC_FILES := $(subst $(LOCAL_PATH)/,,$(LOCAL_SRC_FILES))
51-
52-
ifeq ($(APP_OPTIM),debug)
53-
# Keep symbols by overriding the strip command invoked by ndk-build.
54-
# Note that this will apply to all shared libraries,
55-
# i.e. shared libraries will NOT be stripped
56-
# even though we override it in this Android.mk
57-
cmd-strip :=
58-
endif
59-
60-
# Build the files in this directory as a shared library
61-
include $(BUILD_SHARED_LIBRARY)
62-
63-
64-
65-
66-
678
######################
689
### reactnativejni ###
6910
######################
@@ -91,7 +32,6 @@ LOCAL_SHARED_LIBRARIES := \
9132
libfolly_json \
9233
libglog_init \
9334
libreact_render_runtimescheduler \
94-
libreactnativeutilsjni \
9535
libruntimeexecutor \
9636
libyoga \
9737
logger

ReactCommon/react/renderer/components/progressbar/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ LOCAL_SHARED_LIBRARIES := \
3535
libreact_render_debug \
3636
libreact_render_graphics \
3737
libreact_render_uimanager \
38-
libreactnativeutilsjni \
38+
libreactnativejni \
3939
librrc_view \
4040
libyoga
4141

ReactCommon/react/renderer/components/slider/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ LOCAL_SHARED_LIBRARIES := \
3737
libreact_render_imagemanager \
3838
libreact_render_mapbuffer \
3939
libreact_render_uimanager \
40-
libreactnativeutilsjni \
40+
libreactnativejni \
4141
librrc_image \
4242
librrc_view \
4343
libyoga

ReactCommon/react/renderer/components/switch/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ LOCAL_SHARED_LIBRARIES := \
3535
libreact_render_debug \
3636
libreact_render_graphics \
3737
libreact_render_uimanager \
38-
libreactnativeutilsjni \
38+
libreactnativejni \
3939
librrc_view \
4040
libyoga
4141

ReactCommon/react/renderer/textlayoutmanager/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ LOCAL_SHARED_LIBRARIES := \
3131
libreact_render_telemetry \
3232
libreact_render_uimanager \
3333
libreact_utils \
34-
libreactnativeutilsjni \
34+
libreactnativejni \
3535
libyoga
3636

3737
LOCAL_STATIC_LIBRARIES :=

0 commit comments

Comments
 (0)