Skip to content

Commit ade8598

Browse files
committed
More testing
1 parent e2dce06 commit ade8598

File tree

6 files changed

+14
-10
lines changed

6 files changed

+14
-10
lines changed

packages/react-native/Libraries/AppDelegate/React-RCTAppDelegate.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ header_search_paths = [
3737
"${PODS_ROOT}/Headers/Public/FlipperKit",
3838
"$(PODS_ROOT)/Headers/Public/ReactCommon",
3939
"$(PODS_ROOT)/Headers/Public/React-RCTFabric",
40-
"$(PODS_ROOT)/Headers/Private/Yoga",
40+
# "$(PODS_ROOT)/Headers/Private/Yoga",
4141
].concat(use_hermes ? [
4242
"$(PODS_ROOT)/Headers/Public/React-hermes",
4343
"$(PODS_ROOT)/Headers/Public/hermes-engine"

packages/react-native/React/React-RCTFabric.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ header_search_paths = [
2727
"\"$(PODS_ROOT)/DoubleConversion\"",
2828
"\"$(PODS_ROOT)/RCT-Folly\"",
2929
"\"$(PODS_ROOT)/Headers/Private/React-Core\"",
30-
"\"$(PODS_ROOT)/Headers/Private/Yoga\"",
30+
# "\"$(PODS_ROOT)/Headers/Private/Yoga\"",
3131
"\"$(PODS_ROOT)/Headers/Public/React-Codegen\"",
3232
"\"${PODS_CONFIGURATION_BUILD_DIR}/React-Codegen/React_Codegen.framework/Headers\"",
3333

packages/react-native/ReactCommon/React-Fabric.podspec

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ Pod::Spec.new do |s|
8282
"\"$(PODS_ROOT)/boost\"",
8383
"\"$(PODS_TARGET_SRCROOT)/ReactCommon\"",
8484
"\"$(PODS_ROOT)/RCT-Folly\"",
85-
"\"$(PODS_ROOT)/Headers/Private/Yoga\"",
85+
# "\"$(PODS_ROOT)/Headers/Private/Yoga\"",
8686
]
8787

8888
if ENV['USE_FRAMEWORKS']
@@ -127,7 +127,6 @@ Pod::Spec.new do |s|
127127
sss.source_files = "react/renderer/components/activityindicator/**/*.{m,mm,cpp,h}"
128128
sss.exclude_files = "react/renderer/components/activityindicator/tests"
129129
sss.header_dir = "react/renderer/components/activityindicator"
130-
sss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/Headers/Private/Yoga\"" }
131130
end
132131

133132
ss.subspec "image" do |sss|
@@ -230,7 +229,7 @@ Pod::Spec.new do |s|
230229
sss.source_files = "react/renderer/components/view/**/*.{m,mm,cpp,h}"
231230
sss.exclude_files = "react/renderer/components/view/tests"
232231
sss.header_dir = "react/renderer/components/view"
233-
232+
# ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/Headers/Private/Yoga\"" }
234233
end
235234
end
236235

packages/react-native/ReactCommon/yoga/Yoga.podspec

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,12 @@ Pod::Spec.new do |spec|
5151
source_files = File.join('ReactCommon/yoga', source_files) if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION']
5252
spec.source_files = source_files
5353

54-
header_files = 'yoga/{Yoga,YGEnums,YGMacros,YGValue}.h'
55-
header_files = File.join('ReactCommon/yoga', header_files) if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION']
56-
spec.public_header_files = header_files
54+
public_header_files = 'yoga/{Yoga,YGEnums,YGMacros,YGValue}.h'
55+
public_header_files = File.join('ReactCommon/yoga', public_header_files) if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION']
56+
spec.public_header_files = public_header_files
57+
58+
# Fabric must be able to access private headers (which should not be included in the umbrella header)
59+
all_header_files = 'yoga/**/*.h'
60+
all_header_files = File.join('ReactCommon/yoga', all_header_files) if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION']
61+
spec.private_header_files = Dir.glob(all_header_files) - Dir.glob(public_header_files)
5762
end

packages/react-native/scripts/cocoapods/__tests__/codegen_utils-test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ def get_podspec_no_fabric_no_script
547547
"\"${PODS_ROOT}/Headers/Public/React-Codegen/react/renderer/components\"",
548548
"\"$(PODS_ROOT)/Headers/Private/React-Fabric\"",
549549
"\"$(PODS_ROOT)/Headers/Private/React-RCTFabric\"",
550-
"\"$(PODS_ROOT)/Headers/Private/Yoga\"",
550+
# "\"$(PODS_ROOT)/Headers/Private/Yoga\"",
551551
].join(' ')
552552
},
553553
'dependencies': {

packages/react-native/scripts/cocoapods/codegen_utils.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def get_react_codegen_spec(package_json_file, folly_version: '2021.07.22.00', fa
8383
"\"${PODS_ROOT}/Headers/Public/React-Codegen/react/renderer/components\"",
8484
"\"$(PODS_ROOT)/Headers/Private/React-Fabric\"",
8585
"\"$(PODS_ROOT)/Headers/Private/React-RCTFabric\"",
86-
"\"$(PODS_ROOT)/Headers/Private/Yoga\"",
86+
# "\"$(PODS_ROOT)/Headers/Private/Yoga\"",
8787
]
8888
framework_search_paths = []
8989

0 commit comments

Comments
 (0)