Skip to content

Commit a286c0e

Browse files
gengjiawenfacebook-github-bot
authored andcommitted
Fix RNTester on Windows (#19974)
Summary: Currrent, RNTester can not work on windows. * Fixes #19654. Pull Request resolved: #19974 Differential Revision: D9150453 Pulled By: rafeca fbshipit-source-id: 1bd2046fbe0e8eaadf249604357c2e6acd80455e
1 parent f17047e commit a286c0e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@
103103
"scripts/ios-install-third-party.sh",
104104
"scripts/launchPackager.bat",
105105
"scripts/launchPackager.command",
106-
"scripts/packager.sh",
107106
"scripts/react-native-xcode.sh",
108107
"jest-preset.json",
109108
"jest",
@@ -123,12 +122,12 @@
123122
"third-party-podspecs"
124123
],
125124
"scripts": {
125+
"start": "node ./local-cli/cli.js start",
126126
"test": "jest",
127127
"test-ci": "JEST_JUNIT_OUTPUT=\"reports/junit/js-test-results.xml\" jest --maxWorkers=2 --ci --testResultsProcessor=\"jest-junit\"",
128128
"flow": "flow",
129129
"lint": "eslint .",
130130
"prettier": "prettier \"./**/*.js\" --write",
131-
"start": "/usr/bin/env bash -c './scripts/packager.sh \"$@\" || true' --",
132131
"docker-setup-android": "docker pull reactnativeci/android-base:latest",
133132
"docker-build-android-base": "docker build -t reactnativeci/android-base -f ContainerShip/Dockerfile.android-base .",
134133
"docker-build-android": "docker build -t reactnativeci/android -f ContainerShip/Dockerfile.android .",

scripts/objc-test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function waitForPackager {
5656
if [ "$1" = "test" ]; then
5757

5858
# Start the packager
59-
./scripts/packager.sh --max-workers=1 || echo "Can't start packager automatically" &
59+
npm run start --max-workers=1 || echo "Can't start packager automatically" &
6060
# Start the WebSocket test server
6161
open "./IntegrationTests/launchWebSocketServer.command" || echo "Can't start web socket server automatically"
6262

0 commit comments

Comments
 (0)