Skip to content

Commit 90b98ef

Browse files
javachefacebook-github-bot
authored andcommitted
Resume LockFreeEventDispatcher from onHostResume
Summary: Found that after backgrounding `mShouldStop` would always remain true, which prevents events from being dispatched / scheduled. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D34247567 fbshipit-source-id: 63876986dc0cee5e2a73cb4f8a35d90379d9f8ea
1 parent 7b2d817 commit 90b98ef

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/events/LockFreeEventDispatcherImpl.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,8 @@ public void removeBatchEventDispatchedListener(BatchEventDispatchedListener list
125125

126126
@Override
127127
public void onHostResume() {
128-
maybePostFrameCallbackFromNonUI();
128+
UiThreadUtil.assertOnUiThread();
129+
mCurrentFrameCallback.resume();
129130
}
130131

131132
@Override
@@ -183,6 +184,11 @@ public void doFrame(long frameTimeNanos) {
183184
driveEventBeats();
184185
}
185186

187+
public void resume() {
188+
mShouldStop = false;
189+
maybePost();
190+
}
191+
186192
public void stop() {
187193
mShouldStop = true;
188194
}

0 commit comments

Comments
 (0)