Skip to content

Commit 79c42e7

Browse files
Use C++17 namespace format (#36983)
Summary: Pull Request resolved: #36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 0be5a7bce75dc9f8cde7856684f730f4d6df9202
1 parent 6babe4a commit 79c42e7

File tree

303 files changed

+605
-1211
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

303 files changed

+605
-1211
lines changed

packages/react-native/ReactCommon/react/bridgeless/BufferedRuntimeExecutor.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
#include <cxxreact/MessageQueueThread.h>
1010
#include <algorithm>
1111

12-
namespace facebook {
13-
namespace react {
12+
namespace facebook::react {
1413

1514
BufferedRuntimeExecutor::BufferedRuntimeExecutor(
1615
RuntimeExecutor runtimeExecutor)
@@ -58,5 +57,4 @@ void BufferedRuntimeExecutor::unsafeFlush() {
5857
}
5958
}
6059

61-
} // namespace react
62-
} // namespace facebook
60+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/BufferedRuntimeExecutor.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
#include <atomic>
1212
#include <queue>
1313

14-
namespace facebook {
15-
namespace react {
14+
namespace facebook::react {
1615

1716
class BufferedRuntimeExecutor {
1817
public:
@@ -47,5 +46,4 @@ class BufferedRuntimeExecutor {
4746
std::priority_queue<BufferedWork> queue_;
4847
};
4948

50-
} // namespace react
51-
} // namespace facebook
49+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/JSEngineInstance.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
#include <ReactCommon/RuntimeExecutor.h>
1111
#include <jsi/jsi.h>
1212

13-
namespace facebook {
14-
namespace react {
13+
namespace facebook::react {
1514

1615
/**
1716
* Interface for a class that creates and owns an instance of a JS VM
@@ -23,5 +22,4 @@ class JSEngineInstance {
2322
virtual ~JSEngineInstance() = default;
2423
};
2524

26-
} // namespace react
27-
} // namespace facebook
25+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/PlatformTimerRegistry.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99

1010
#include <cstdint>
1111

12-
namespace facebook {
13-
namespace react {
12+
namespace facebook::react {
1413

1514
/**
1615
* This interface is implemented by each platform.
@@ -30,5 +29,4 @@ class PlatformTimerRegistry {
3029

3130
using TimerManagerDelegate = PlatformTimerRegistry;
3231

33-
} // namespace react
34-
} // namespace facebook
32+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/ReactInstance.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
#include <tuple>
2323
#include <utility>
2424

25-
namespace facebook {
26-
namespace react {
25+
namespace facebook::react {
2726

2827
// Looping on \c drainMicrotasks until it completes or hits the retries bound.
2928
static void performMicrotaskCheckpoint(jsi::Runtime &runtime) {
@@ -454,5 +453,4 @@ void ReactInstance::handleMemoryPressureJs(int pressureLevel) {
454453
}
455454
}
456455

457-
} // namespace react
458-
} // namespace facebook
456+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/ReactInstance.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
#include <react/bridgeless/TimerManager.h>
1717
#include <react/renderer/runtimescheduler/RuntimeScheduler.h>
1818

19-
namespace facebook {
20-
namespace react {
19+
namespace facebook::react {
2120

2221
struct CallableModule {
2322
explicit CallableModule(jsi::Function factory)
@@ -76,5 +75,4 @@ class ReactInstance final {
7675
std::shared_ptr<bool> hasFatalJsError_;
7776
};
7877

79-
} // namespace react
80-
} // namespace facebook
78+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/TimerManager.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
#include <cxxreact/SystraceSection.h>
1111
#include <utility>
1212

13-
namespace facebook {
14-
namespace react {
13+
namespace facebook::react {
1514

1615
TimerManager::TimerManager(
1716
std::unique_ptr<PlatformTimerRegistry> platformTimerRegistry) noexcept
@@ -412,5 +411,4 @@ void TimerManager::attachGlobals(jsi::Runtime &runtime) {
412411
}));
413412
}
414413

415-
} // namespace react
416-
} // namespace facebook
414+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/TimerManager.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414

1515
#include "PlatformTimerRegistry.h"
1616

17-
namespace facebook {
18-
namespace react {
17+
namespace facebook::react {
1918

2019
/*
2120
* A HostObject subclass representing the result of a setTimeout call.
@@ -113,5 +112,4 @@ class TimerManager {
113112
std::vector<uint32_t> reactNativeMicrotasksQueue_;
114113
};
115114

116-
} // namespace react
117-
} // namespace facebook
115+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/hermes/HermesInstance.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
using namespace facebook::hermes;
1919
using namespace facebook::jsi;
2020

21-
namespace facebook {
22-
namespace react {
21+
namespace facebook::react {
2322

2423
#ifdef HERMES_ENABLE_DEBUGGER
2524

@@ -119,5 +118,4 @@ std::unique_ptr<jsi::Runtime> HermesInstance::createJSRuntime(
119118
return hermesRuntime;
120119
}
121120

122-
} // namespace react
123-
} // namespace facebook
121+
} // namespace facebook::react

packages/react-native/ReactCommon/react/bridgeless/hermes/HermesInstance.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
#include <jsi/jsi.h>
1212
#include <react/config/ReactNativeConfig.h>
1313

14-
namespace facebook {
15-
namespace react {
14+
namespace facebook::react {
1615

1716
class HermesInstance {
1817
public:
@@ -24,5 +23,4 @@ class HermesInstance {
2423
std::shared_ptr<::hermes::vm::CrashManager> cm) noexcept;
2524
};
2625

27-
} // namespace react
28-
} // namespace facebook
26+
} // namespace facebook::react

0 commit comments

Comments
 (0)