From 77a02c0d83dbfcd9a5397cf63e1ab2e6c94cfdde Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Fri, 15 Jun 2018 12:59:38 -0700 Subject: [PATCH] deprecate ReactFragmentActivity (#19741) Summary: Android Support Library page says https://developer.android.com/topic/libraries/support-library/ > Caution: Starting with Support Library release 26.0.0 (July 2017), the minimum supported API level across most support libraries has increased to Android 4.0 (API level 14) for most library packages. For more information, see Version Support and Package Names in this document. _android.support.v4.app.FragmentActivity_ is used to support **Fragment**s on Android API versions below 11. Now, we support only API version 14 and above, it's ok to remove _ReactFragmentActivity_ that extends _FragmentActivity_. Once ReactFragmentActivity removed, we can remove some codes that use _android.support.v4_ to work support _ReactFragmentActivity_ on **unsupported** Android versions. CI is failing for unknown reasons: https://circleci.com/gh/dulmandakh/react-native/278 > Received 'killed' signal Everything will build and work just fine, except showing _ ReactFragmentActivity_ as deprecated Closes https://github.com/facebook/react-native/pull/19741 Differential Revision: D8454968 Pulled By: hramos fbshipit-source-id: e5f901438ef764163af013fe854904a28c73070a --- .../main/java/com/facebook/react/ReactFragmentActivity.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactFragmentActivity.java b/ReactAndroid/src/main/java/com/facebook/react/ReactFragmentActivity.java index 10bbd9d89639eb..b104b91e4ef521 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactFragmentActivity.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactFragmentActivity.java @@ -19,9 +19,11 @@ import com.facebook.react.modules.core.PermissionListener; /** - * Base Activity for React Native applications. Like {@link ReactActivity} but extends - * {@link FragmentActivity} instead of {@link android.app.Activity}. + * @deprecated + * ReactFragmentActivity will be removed in 0.57 release. + * Use {@link ReactActivity} instead. */ +@Deprecated public abstract class ReactFragmentActivity extends FragmentActivity implements DefaultHardwareBackBtnHandler, PermissionAwareActivity {