Skip to content

Commit 6f4c4b5

Browse files
makovkastarfacebook-github-bot
authored andcommitted
Include only Java classes in zip archive of generated files
Summary: Changelog: [General] [Changed] - Include only Java classes in zip archive of generated files for JS codegen This diff adds one more Buck rule to copy only Java files to a temporary dir, so that the zip_rule will only package the Java classes and skip C++ files. It makes the generated code more organized and decreases the time to create the ZIP-archive. Reviewed By: rickhanlonii Differential Revision: D16540781 fbshipit-source-id: cbc99b5fe28b6af5375a88652cefb30e672ed527
1 parent 59db059 commit 6f4c4b5

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

packages/react-native-codegen/DEFS.bzl

+12-5
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,15 @@ def rn_codegen(
2626
generate_event_emitter_h_name = "generate_event_emitter_h-{}".format(name)
2727
generate_props_cpp_name = "generate_props_cpp-{}".format(name)
2828
generate_props_h_name = "generated_props_h-{}".format(name)
29-
generate_props_java_name = "generate_props_java-{}".format(name)
3029
generate_tests_cpp_name = "generate_tests_cpp-{}".format(name)
3130
generate_shadow_node_cpp_name = "generated_shadow_node_cpp-{}".format(name)
3231
generate_shadow_node_h_name = "generated_shadow_node_h-{}".format(name)
3332
generate_module_h_name = "generate_module_h-{}".format(name)
3433
generate_module_cpp_name = "generate_module_cpp-{}".format(name)
3534
generate_module_hobjcpp_name = "generate_module_hobjcpp-{}".format(name)
3635
generate_module_mm_name = "generate_module_mm-{}".format(name)
36+
copy_generated_java_files = "copy_generated_java_files-{}".format(name)
37+
zip_generated_java_files = "zip_generated_java_files-{}".format(name)
3738

3839
fb_native.genrule(
3940
name = generate_fixtures_rule_name,
@@ -78,10 +79,16 @@ def rn_codegen(
7879
out = "Props.h",
7980
)
8081

82+
fb_native.genrule(
83+
name = copy_generated_java_files,
84+
cmd = "mkdir $OUT && find $(location :{}) -name '*.java' -exec cp {{}} $OUT \;".format(generate_fixtures_rule_name),
85+
out = "java",
86+
)
87+
8188
fb_native.zip_file(
82-
name = generate_props_java_name,
83-
srcs = [":{}".format(generate_fixtures_rule_name)],
84-
out = "{}.src.zip".format(generate_props_java_name),
89+
name = zip_generated_java_files,
90+
srcs = [":{}".format(copy_generated_java_files)],
91+
out = "{}.src.zip".format(zip_generated_java_files),
8592
visibility = ["PUBLIC"],
8693
)
8794

@@ -219,7 +226,7 @@ def rn_codegen(
219226
rn_android_library(
220227
name = "generated_components_java-{}".format(name),
221228
srcs = [
222-
":{}".format(generate_props_java_name),
229+
":{}".format(zip_generated_java_files),
223230
],
224231
visibility = ["PUBLIC"],
225232
deps = [

0 commit comments

Comments
 (0)