From 4305a291a9408ca65847994bbec42f1fbc97071d Mon Sep 17 00:00:00 2001 From: Will Holen Date: Mon, 13 Apr 2020 19:45:08 -0700 Subject: [PATCH] Upgrade Hermes dependency to 0.5.0 Summary: Use the latest published release of hermes-engine. Update RN to invoke `hermesc` instead of `hermes`. Changelog: [Android] [Changed] - Upgraded to Hermes 0.5.0 allow-large-files Reviewed By: mhorowitz Differential Revision: D20998564 fbshipit-source-id: 4824e273bcb044029a5a7e9379f168d3da47da50 --- RNTester/android/app/build.gradle | 2 +- package.json | 2 +- react.gradle | 2 +- yarn.lock | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/RNTester/android/app/build.gradle b/RNTester/android/app/build.gradle index ee86770ede2e4e..0a36475ade519b 100644 --- a/RNTester/android/app/build.gradle +++ b/RNTester/android/app/build.gradle @@ -71,7 +71,7 @@ project.ext.react = [ root: "$rootDir", inputExcludes: ["android/**", "./**", ".gradle/**"], composeSourceMapsPath: "$rootDir/scripts/compose-source-maps.js", - hermesCommand: "../../../node_modules/hermes-engine/%OS-BIN%/hermes", + hermesCommand: "../../../node_modules/hermes-engine/%OS-BIN%/hermesc", enableHermesForVariant: { def v -> v.name.contains("hermes") } ] diff --git a/package.json b/package.json index abd8835dc34f2b..cd3f2d68d73b95 100644 --- a/package.json +++ b/package.json @@ -95,7 +95,7 @@ "event-target-shim": "^5.0.1", "fbjs": "^1.0.0", "fbjs-scripts": "^1.1.0", - "hermes-engine": "~0.4.0", + "hermes-engine": "~0.5.0", "invariant": "^2.2.4", "jsc-android": "^245459.0.0", "metro-babel-register": "0.59.0", diff --git a/react.gradle b/react.gradle index d87182df8b58cc..e6e5afe2dc2158 100644 --- a/react.gradle +++ b/react.gradle @@ -30,7 +30,7 @@ def reactRoot = file(config.root ?: "../../") def inputExcludes = config.inputExcludes ?: ["android/**", "ios/**"] def bundleConfig = config.bundleConfig ? "${reactRoot}/${config.bundleConfig}" : null ; def enableVmCleanup = config.enableVmCleanup == null ? true : config.enableVmCleanup -def hermesCommand = config.hermesCommand ?: "../../node_modules/hermes-engine/%OS-BIN%/hermes" +def hermesCommand = config.hermesCommand ?: "../../node_modules/hermes-engine/%OS-BIN%/hermesc" def reactNativeDevServerPort() { def value = project.getProperties().get("reactNativeDevServerPort") diff --git a/yarn.lock b/yarn.lock index 14c20dd0311dd2..07708118ebc80b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3837,10 +3837,10 @@ has@^1.0.1, has@^1.0.3: dependencies: function-bind "^1.1.1" -hermes-engine@~0.4.0: - version "0.4.0" - resolved "https://registry.yarnpkg.com/hermes-engine/-/hermes-engine-0.4.0.tgz#ea3113d472871ca4791f2d75d9f68b25d82ef92c" - integrity sha512-7AO/K64GuVtcpUwUKDxyQXFN45RlqWrMIPMte6AeegMQMBh+MWuMU6ZOw8Jc7FGtsgiRqJRp+UX4+4UrFQXJ/A== +hermes-engine@~0.5.0: + version "0.5.0" + resolved "https://registry.yarnpkg.com/hermes-engine/-/hermes-engine-0.5.0.tgz#d914acce72e9657b3c98875ad3f9094d8643f327" + integrity sha512-jSuHiOhdh2+IF3bH2gLpQ37eMkdUrEb9GK6PoG3rLRaUDK3Zn2Y9fXM+wyDfoUTA3gz9EET0/IIWk5k21qp4kw== home-or-tmp@^3.0.0: version "3.0.0"