Skip to content

Commit

Permalink
Fix ReactEditText crash
Browse files Browse the repository at this point in the history
Summary:
Found this crash when rendering ReactEditText under Venice, from comment it's supposed to be called only in Paper, so I adde a Venice check to avoid calling this method.

{F446844248}

Changelog:
[Android][Changed] - Add a new check to avoid calling this method

Reviewed By: mdvacca

Differential Revision: D26781457

fbshipit-source-id: f4c2e890156a37e35aa153c736b50924254e67bc
  • Loading branch information
luluwu2032 authored and facebook-github-bot committed Mar 5, 2021
1 parent a65cd68 commit 2b70856
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -734,8 +734,9 @@ private void setIntrinsicContentSize() {
// wrapper 100% of the time.
// Since the LocalData object is constructed by getting values from the underlying EditText
// view, we don't need to construct one or apply it at all - it provides no use in Fabric.
if (!mFabricViewStateManager.hasStateWrapper()) {
ReactContext reactContext = getReactContext(this);
ReactContext reactContext = getReactContext(this);

if (!mFabricViewStateManager.hasStateWrapper() && !reactContext.isBridgeless()) {
final ReactTextInputLocalData localData = new ReactTextInputLocalData(this);
UIManagerModule uiManager = reactContext.getNativeModule(UIManagerModule.class);
if (uiManager != null) {
Expand Down

0 comments on commit 2b70856

Please sign in to comment.