Skip to content

Conversation

@GioLogist
Copy link
Contributor

@GioLogist GioLogist commented Dec 2, 2017

None of the inherited prop pages mention these props, so it should be mentioned here.

None of the inherited prop pages mention these props, so it should be mentioned here.
@brentvatne
Copy link
Contributor

hey! I agree this is a valuable change, however be sure to read the guide in the README on updating the 'versioned docs' -- https://github.com/facebook/react-native-website#versioned-docs

None of the inherited prop pages mention these props, so it should be mentioned here.
@GioLogist
Copy link
Contributor Author

@brentvatne Ah! Just read it through and adjusted the PR accordingly 🤘🏻

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants