From bcf6b1aaf3e15b67b5c797f95c639c810c13db32 Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Fri, 4 Jan 2019 08:07:27 -0800 Subject: [PATCH] Possible fix for react-devtools-core break Some time ago, when updating Babel and Webpack (PR #1235) the 'libraryTarget' Webpack setting was accidentally changed from 'umd' to default (global) which, I believe, caused the subsequent 3.5.0 react-devtools/react-devtools-core releases to break. This change restores the 'libraryTarget' value to 'umd' for the backend.' git status --- packages/react-devtools-core/package.json | 2 +- packages/react-devtools-core/webpack.backend.js | 2 ++ packages/react-devtools/package.json | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/react-devtools-core/package.json b/packages/react-devtools-core/package.json index ab4afe627b..bd8c21b403 100644 --- a/packages/react-devtools-core/package.json +++ b/packages/react-devtools-core/package.json @@ -1,6 +1,6 @@ { "name": "react-devtools-core", - "version": "3.5.0", + "version": "3.5.1", "description": "Use react-devtools outside of the browser", "main": "./build/backend.js", "repository": { diff --git a/packages/react-devtools-core/webpack.backend.js b/packages/react-devtools-core/webpack.backend.js index cf61b82423..a05ec34257 100644 --- a/packages/react-devtools-core/webpack.backend.js +++ b/packages/react-devtools-core/webpack.backend.js @@ -24,6 +24,8 @@ module.exports = { output: { path: __dirname + '/build', filename: '[name].js', + library: '[name]', + libraryTarget: 'umd', }, plugins: __DEV__ ? [] : [ // Ensure we get production React diff --git a/packages/react-devtools/package.json b/packages/react-devtools/package.json index 5f7848bc25..0c3c564032 100644 --- a/packages/react-devtools/package.json +++ b/packages/react-devtools/package.json @@ -1,6 +1,6 @@ { "name": "react-devtools", - "version": "3.5.0", + "version": "3.5.1", "description": "Use react-devtools outside of the browser", "repository": { "url": "https://github.com/facebook/react-devtools.git", @@ -26,7 +26,7 @@ "electron": "^1.8.7", "ip": "^1.1.4", "minimist": "^1.2.0", - "react-devtools-core": "^3.5.0", + "react-devtools-core": "^3.5.1", "update-notifier": "^2.1.0" } }