Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support Custom Color for Table Selection Highlight #6655

Closed
dineug opened this issue Sep 21, 2024 · 1 comment · Fixed by #6658
Closed

Feature: Support Custom Color for Table Selection Highlight #6655

dineug opened this issue Sep 21, 2024 · 1 comment · Fixed by #6658
Labels
enhancement Improvement over existing feature

Comments

@dineug
Copy link

dineug commented Sep 21, 2024

Description

I am working on a Lexical Editor for dark themes. It would be great to support custom colors for table selection highlights.

table_selection_highlight.mp4

Impact

This will help achieve a higher-quality dark theme.
@dineug dineug added the enhancement Improvement over existing feature label Sep 21, 2024
@etrepum
Copy link
Collaborator

etrepum commented Sep 21, 2024

@zurfyx is there a reason why this selection color is hard-coded as a style, rather than implemented as a class and/or using css custom properties?

@hamza221 hamza221 mentioned this issue Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement over existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lexical-table] Bug Fix: get table-cell background selection color from a class hamza221/lexical
2 participants
@etrepum @dineug