adds ability to pass custom reporter options

[flovilmart]

Istanbul-reporters recently changed their coverage reporting behaviour by introducing the projectRoot options.

This PR attempts to right the wrong and let a jest user configure the projectRoot right from the jest config by introducing the configuration through the well known tuple pattern.

Fixes #4103

[codecov-io]

Codecov Report

Merging #9572 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9572      +/-   ##
==========================================
+ Coverage   65.04%   65.08%   +0.03%     
==========================================
  Files         286      286              
  Lines       12140    12143       +3     
  Branches     3008     3009       +1     
==========================================
+ Hits         7897     7903       +6     
  Misses       3605     3605              
+ Partials      638      635       -3

Impacted Files	Coverage Δ
packages/jest-reporters/src/coverage_reporter.ts	53.89% <100%> (+2.67%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47ade4...bf6d69f. Read the comment docs.

[SimenB]

This is great 👍 Could you add a test? And a changelog entry

[flovilmart]

@SimenB I was troubled because I didn't spot any test initially on the Istanbul-reporters loading 🤦‍♂ . I added a test that covers both use cases (simple loading as well as tuple loading).

[SimenB]

I wonder if jest should always set projectRoot to config.rootDir? Wouldn't that fix #7176?

[SimenB]

Should be called with 10 no? I think it makes sense for user options to always override Jest's defaults

[flovilmart]

I think it makes sense for user options to always override Jest's defaults

I wasn't sure what your stance would be about this option, I'll change it

[flovilmart]

I wonder if jest should always set projectRoot to config.rootDir? Wouldn't that fix #7176?

In the case of #7176, I believe the reporter involved is text-reporter and projectRoot is not set for this reporter. (https://github.com/istanbuljs/istanbuljs/blob/master/packages/istanbul-reports/lib/text-summary/index.js) It seems to be consistent with the implementation (I commented on the issue regarding this).

[SimenB]

This is great, thanks! We could set projectRoot, but that's separate

[flovilmart]

Thanks @SimenB !

[flovilmart]

@SimenB how does the release schedule usually look like? We have ugly workarounds in our codebase waiting for this patch, and I’d be happy to prep a release if is can help getting a patch out :)

[SimenB]

Quite slow 🙁 I'll try to get a release out after we've verified fixes for #9457, but it's always slow as I don't have publish access and I need to get somebody at FB to make a release.

I recommend using patch-package or some such in the meanwhile.

[flovilmart]

Thanks @SimenB !

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.