Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused deps from @jest/reporters #9462

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 24, 2020

Summary

Noticed when I was messing with the reporters. Technically breaking for TS users if they import these types, but meh. They should import TestFramework from https://github.com/facebook/jest/blob/eee81208163d2b64171a6b7eec13a8a1aebfc901/packages/jest-runner/src/types.ts#L40-L46

Test plan

Green CI

@codecov-io
Copy link

Codecov Report

Merging #9462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9462   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files         283      283           
  Lines       12104    12104           
  Branches     2990     2990           
=======================================
  Hits         7863     7863           
  Misses       3604     3604           
  Partials      637      637

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee8120...e623937. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants