Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make arguments to methods in base reporter optional #9159

Merged
merged 2 commits into from
Nov 10, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 10, 2019

Summary

If people extend the class they won't have to pass the arguments to please TS

Test plan

Green CI

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #9159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9159   +/-   ##
=======================================
  Coverage   64.83%   64.83%           
=======================================
  Files         278      278           
  Lines       11732    11732           
  Branches     2882     2883    +1     
=======================================
  Hits         7607     7607           
  Misses       3508     3508           
  Partials      617      617
Impacted Files Coverage Δ
packages/jest-reporters/src/base_reporter.ts 80% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb768e...64b76b3. Read the comment docs.

@thymikee thymikee changed the title chore: make arguements to methods in base reporter optional chore: make arguments to methods in base reporter optional Nov 10, 2019
@thymikee thymikee merged commit fe6ebba into jestjs:master Nov 10, 2019
@SimenB SimenB deleted the base-reporter-args branch November 10, 2019 13:49
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants