-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of Node 6 support #8455
Conversation
I like it! @scotthovestadt are we gonna make any more 24 releases, or can we start breaking things? |
Codecov Report
@@ Coverage Diff @@
## master #8455 +/- ##
==========================================
- Coverage 63.46% 63.38% -0.09%
==========================================
Files 274 274
Lines 11385 11341 -44
Branches 2771 2760 -11
==========================================
- Hits 7226 7188 -38
+ Misses 3546 3541 -5
+ Partials 613 612 -1
Continue to review full report at Codecov.
|
f08297c
to
c46a83d
Compare
Can you update |
c46a83d
to
0e49085
Compare
Two failing snapshots due to changed stack trace (removed async await transpilation, I guess). Mind updating them? 🙂 |
@SimenB Done |
One of the CI steps is failing as the process runs out of memory. As far as I can see there's 4096 MBs available in CircleCI, so we can bump it a little: |
This test fails on master for a long time. |
3cfbe1b
to
0d39549
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Nodejs team stop support of
node 6
since 30 april.I propose to remove support for
node 6
.Many projects have already removed support of this version. For example
Angular
,Webpack 5 alpha
,ts-loader
.Also i removed polyfill for
v8.serialize
because it supports sincenode 8
Test plan