Declare global prototype in JSDOMEnvironment to fix issue #8347 #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested changes
Apr 21, 2019
|
@SimenB I updated PR and changelog. |
Codecov Report
@@ Coverage Diff @@
## master #8352 +/- ##
==========================================
+ Coverage 62.18% 62.18% +<.01%
==========================================
Files 266 266
Lines 10704 10703 -1
Branches 2604 2604
==========================================
Hits 6656 6656
+ Misses 3462 3461 -1
Partials 586 586
Continue to review full report at Codecov.
|
SimenB
reviewed
Apr 21, 2019
lh0x00
commented
Apr 21, 2019
jeysal
reviewed
Apr 21, 2019
jeysal
reviewed
Apr 21, 2019
SimenB
approved these changes
Apr 21, 2019
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have described an issue at #8347.
We know ignores were not emitted by Typescript creating declaration files (ref microsoft/TypeScript#20360) and we can't build in your Typescript project if not skip checking types in libraries using.
I re-declared
globalprototype in JSDOMEnvironment class. I checked in my project and build files.