Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --forceExit and "did not exit for one second" message colors. #8329

Merged
merged 6 commits into from
Apr 14, 2019

Conversation

scotthovestadt
Copy link
Contributor

Summary

Currently, the --forceExit warning is misleading because it's a bold, red message for something that you've specifically opted in to. When I run tests, my eye is looking for red to show me that something failed. If my project needs to use --forceExit, I shouldn't see red every single time. Red should be reserved for errors.

I've updated the message. It's now on one line and white. It's something you will see every single run, it shouldn't draw your eye too much.

Screen Shot 2019-04-13 at 11 57 04 AM

Similarly, the "Jest did not exit for one second" message is currently shown in red. This message shouldn't show every time and should catch the user's eye. However, it's not an error by itself, it's a warning. It's possible that the test run completes successfully after this message is printed. I've updated the color to match.

Screen Shot 2019-04-13 at 11 58 09 AM

Test plan

  • All tests pass.
  • Updated snapshots.
  • Tested manually.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better! Have you considered switching to console.warn for these messages?

packages/jest-cli/src/cli/index.ts Outdated Show resolved Hide resolved
packages/jest-cli/src/cli/index.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #8329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8329   +/-   ##
=======================================
  Coverage   62.17%   62.17%           
=======================================
  Files         266      266           
  Lines       10694    10694           
  Branches     2602     2603    +1     
=======================================
  Hits         6649     6649           
  Misses       3459     3459           
  Partials      586      586

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bcefb...cc8d59f. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants