Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React.memo in pretty-format #7891

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Support React.memo in pretty-format #7891

merged 2 commits into from
Feb 14, 2019

Conversation

bensampaio
Copy link
Contributor

@bensampaio bensampaio commented Feb 14, 2019

  • Handle memo components in the getType function so that a name like Memo(ComponentName) is shown instead of UNDEFINED.

Summary

This fixes #7883.

Test plan

Added one test similar to the ones for forwardRef and Context.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@bensampaio bensampaio changed the title Fix #7883 React.memo with snapshot testing results in <UNDEFINED> React.memo with snapshot testing results in <UNDEFINED> Feb 14, 2019
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Please add a test and changelog entry :)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

* Handle memo components in the `getType` function so that a name like `Memo(ComponentName)` is returned instead of `UNDEFINED`.
@bensampaio
Copy link
Contributor Author

@thymikee I added the tests and changed the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
@thymikee thymikee changed the title React.memo with snapshot testing results in <UNDEFINED> Support React.memo in pretty-format Feb 14, 2019
@codecov-io
Copy link

Codecov Report

Merging #7891 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7891   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         173      173           
  Lines        6424     6424           
  Branches        5        6    +1     
=======================================
  Hits         3736     3736           
  Misses       2686     2686           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e31173...a47f95d. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit af1ab24 into jestjs:master Feb 14, 2019
@bensampaio
Copy link
Contributor Author

Awesome, thanks for such fast feedback and review process! 😄 Is it possible to give any prediction on a release date?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React.memo with snapshot testing results in <UNDEFINED>
5 participants