-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React.memo in pretty-format #7891
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Please add a test and changelog entry :)
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
* Handle memo components in the `getType` function so that a name like `Memo(ComponentName)` is returned instead of `UNDEFINED`.
@thymikee I added the tests and changed the CHANGELOG. |
Codecov Report
@@ Coverage Diff @@
## master #7891 +/- ##
=======================================
Coverage 58.15% 58.15%
=======================================
Files 173 173
Lines 6424 6424
Branches 5 6 +1
=======================================
Hits 3736 3736
Misses 2686 2686
Partials 2 2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Awesome, thanks for such fast feedback and review process! 😄 Is it possible to give any prediction on a release date? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
getType
function so that a name likeMemo(ComponentName)
is shown instead ofUNDEFINED
.Summary
This fixes #7883.
Test plan
Added one test similar to the ones for
forwardRef
andContext
.