Fix for mocks not working with module name mapper #7787
Conversation
packages/jest-runtime/src/__tests__/runtime_gen_mock_from_module.test.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #7787 +/- ##
==========================================
- Coverage 68.34% 68.27% -0.07%
==========================================
Files 252 252
Lines 9707 9684 -23
Branches 5 6 +1
==========================================
- Hits 6634 6612 -22
+ Misses 3071 3070 -1
Partials 2 2
Continue to review full report at Codecov.
|
|
The names come from the reproduction case - I don't think they matter or takes away from the clarity of the tests |
|
|
||
| test('relative import', () => { | ||
| const track = new Track(); | ||
| expect(track.someRandomFunction).not.toBeCalled(); |
There was a problem hiding this comment.
@grosto, I'm currently experiencing the problem this PR was supposed to solve; my aliased components aren't being mocked.
Reviewing this expected solution, I suspect it's broken again and was not caught because of this test. I believe this expectation here would always be true event if the mock is not successful. In order for this test to be valuable, someRandomFunction should be called if there is no mock, but I don't see any case where it would be called.
There was a problem hiding this comment.
@dbroytman could you open up a new issue with a reproducion? Or even better, a PR fixing it 🙂
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #4262. Closes #7668
There were two bugs with how module name mapper and mocks interact. First,
_generateMockwas calling_resolveModulemethod which does not handle mapped modules, and secondrequireMockwas assuming that mapped module was a manual mock.Test plan
I have added one additional unit test and copied integration test from #7668