pretty-format: Omit unnecessary symbol filter for object keys #7457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Goals:
Object.keys
returnsproperties withstring keys, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Return_valueThis dubious filter began in pretty-format 1.1.0 to remove string keys whose values look like a symbol description:
However, code change was unnecessary because the test added in 1.1.0 passes with 1.0.0 :(
I decided to leave
if (Object.getOwnPropertySymbols) { … }
for now, because method isn’t in IE:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertySymbols#Browser_compatibility
Test plan
Existing test
prints an object with properties and symbols
still passes (for example, properties with symbol keys are not duplicated)