Fix duplicate module detection #7333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Nov 6, 2018
rubennorte
force-pushed
the
fix-duplicate-module-detection
branch
from
f5321bf
to
1f7cc58
Compare
SimenB
approved these changes
Nov 7, 2018
rubennorte
force-pushed
the
fix-duplicate-module-detection
branch
from
1f7cc58
to
8f099fd
Compare
rubennorte
force-pushed
the
fix-duplicate-module-detection
branch
from
8f099fd
to
a2e45e8
Compare
rubennorte
commented
Nov 7, 2018
| @@ -108,18 +108,25 @@ const object = data => Object.assign(Object.create(null), data); | |||
| const createMap = obj => new Map(Object.keys(obj).map(key => [key, obj[key]])); | |||
|
|
|||
| // Jest toEqual does not match Map instances from different contexts | |||
There was a problem hiding this comment.
@mjesun do you think we should fix this in Jest matchers? Given it's a very unfrequent use case we might just use this solution.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some code in the haste map checked if the module ID changed to determine if the file should be rechecked for duplication or not. The module ID isn't available at that point (it's extracted later from the filename) so it was returning all the files all the time.
Also improved the data structure used to store those deprecated files to remove the number of newly allocated objects.
Test plan
Updated tests.