Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print info about passWithNoTests flag #7309

Merged
merged 2 commits into from
Dec 24, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 31, 2018

Summary

We've gotten some issue here and there about it, thoughts on advertising the flag in the message?

Docs: https://jestjs.io/docs/en/cli#passwithnotests

Test plan

image

@codecov-io
Copy link

Codecov Report

Merging #7309 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7309   +/-   ##
=======================================
  Coverage   66.63%   66.63%           
=======================================
  Files         241      241           
  Lines        9333     9333           
  Branches        5        5           
=======================================
  Hits         6219     6219           
  Misses       3111     3111           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-cli/src/getNoTestFoundVerbose.js 0% <ø> (ø) ⬆️
packages/jest-cli/src/getNoTestFound.js 57.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5310c1...72f1300. Read the comment docs.

@SimenB SimenB merged commit 02aee62 into jestjs:master Dec 24, 2018
@SimenB SimenB deleted the no-test-found-message branch December 24, 2018 12:53
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants