-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readConfigs
method to jest-config
#7096
Add readConfigs
method to jest-config
#7096
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7096 +/- ##
==========================================
- Coverage 66.67% 66.66% -0.01%
==========================================
Files 253 253
Lines 10597 10597
Branches 3 3
==========================================
- Hits 7066 7065 -1
- Misses 3530 3531 +1
Partials 1 1
Continue to review full report at Codecov.
|
Would this make sense as en export from (Changelog? :D) |
@SimenB I'm not sure it'd be useful as it's not used by any other Jest package. We're good using an internal module even if we have to have special care about breaking changes on it. Also I don't think it'd feel natural to have an exported function in the package that represents the CLI. Edit: I didn't read properly that you meant the "jest-config" package. I'll explore if it fits there nicely. |
Yeah, |
…jest-cli to jest-config
1d465a5
to
cfafaa8
Compare
readConfigs
method to jest-config
@SimenB moved to |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This just moves the method to get the normalized configuration from the command line args and the project list to
jest-config
.Test plan
Added a smoke test in
jest-config
(just like we did forreadConfig
) and the current tests forjest-cli
should still pass.