[docs]: Add link to jest-extended in expect docs #7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Sep 30, 2018
| @@ -6,6 +6,8 @@ original_id: expect | |||
|
|
|||
| When you're writing tests, you often need to check that values meet certain conditions. `expect` gives you access to a number of "matchers" that let you validate different things. | |||
|
|
|||
| For additional Jest matchers maintained by the Jest Community check out [`jest-extended`](https://github.com/jest-community/jest-extended). | |||
There was a problem hiding this comment.
mind adding it to all versioned docs?
|
Great idea! |
mattphillips
force-pushed
the
expect-docs-extended
branch
from
e65e976
to
b5c8c94
Compare
Codecov Report
@@ Coverage Diff @@
## master #7078 +/- ##
=========================================
Coverage ? 66.63%
=========================================
Files ? 251
Lines ? 10542
Branches ? 3
=========================================
Hits ? 7025
Misses ? 3516
Partials ? 1Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a link for
jest-extendedin theexpectdocs.We're still seeing quite a lot of issues around new matchers etc being opened, I think if we link directly out to community matchers in the docs it might help.
Test plan