Fix mocking inherited static properties and prototype-less objects #7003
Conversation
rubennorte
force-pushed
the
fix-mocks
branch
from
50af289
to
cd737c6
Compare
|
|
||
| expect(typeof ClassBarMock.foo).toBe('function'); | ||
| expect(typeof ClassBarMock.fooProp).toBe('function'); | ||
| expect(ClassBarMock.foo.mock).not.toBeUndefined(); |
| expect(BarMock.bind).toBe(mockGlobals.Function.prototype.bind); | ||
| }); | ||
|
|
||
| it('does not mock methods from Function.prototype (in mock context)', () => { |
There was a problem hiding this comment.
This is why I had to revert #6921. In this specific test we use builtins from the host, not the ones passed to ModuleMockerClass. This test covers that too.
rubennorte
force-pushed
the
fix-mocks
branch
from
cd737c6
to
19dfec9
Compare
rubennorte
force-pushed
the
fix-mocks
branch
from
19dfec9
to
24cd5c4
Compare
| class Foo {} | ||
| class Bar extends Foo {} | ||
| Bar; | ||
| `, |
There was a problem hiding this comment.
There's a weird alignment going on here... Do instead:
const Bar = vm.runInContext(
`
class Foo {}
class Bar extends Foo {}
Bar;
`,
mockContext,
);There was a problem hiding this comment.
That's all prettier 🤷🏻♂️
There was a problem hiding this comment.
you can add a space inside the literal to align the backticks, prettier won't strip them
There was a problem hiding this comment.
Correct; once you're in backtick mode, prettier is not changing the contents.
| expect(BarMock.bind).toBe(mockGlobals.Function.prototype.bind); | ||
| }); | ||
|
|
||
| it('does not mock methods from RegExp.prototype', () => { |
There was a problem hiding this comment.
Didn't we say we were going to remove the RegExp whitelisting? (i.e. either all or none).
There was a problem hiding this comment.
That would be a breaking change. RegExp is still a special case because we don't mock their methods (and the rest of built-ins are already managed in collections or here).
| ` | ||
| const bar = /bar/; | ||
| bar; | ||
| `, |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #6994 and #6995, and generalizes some code from jest-mock.
Re-applies #6921 fixing its bugs.
Test plan
Added new test cases and tested in FB infra.