-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong messages for nthCalledWith #6340
Conversation
@SimenB The old branch was force-updated and the PR was closed automatically, so I recreate another one. No new tests are added, but I fixed the original snapshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Math checks out
Codecov Report
@@ Coverage Diff @@
## master #6340 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 228 228
Lines 8705 8705
Branches 4 3 -1
=======================================
Hits 5562 5562
Misses 3142 3142
Partials 1 1 Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
formatMismatchedCalls
prints the last x(usually x = 1) calls messages, but is not suitable fornthCalledWith
. Same with #6338.Test plan