Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: option to not escape strings in diff messages #5661

Merged
merged 4 commits into from
Sep 17, 2018

Conversation

maciej-ka
Copy link
Contributor

#5660

This MR adds an option to disable special chars escaping in prettyFormat prettyFormat(val, {escapeString: false}).

But in order to solve #5660 I would need a way to set escapeString option in jest and pass it to prettyFormat invocation. I would need a help, how to pass that config option there.

Adding a "prettyFormatOptions" parameter to a stack of methods is one way, but ... perhaps there is some singleton access to the Jest config?

@SimenB
Copy link
Member

SimenB commented Apr 14, 2018

Sorry about the lack of feedback! I think a config option likeserializerOptions or prettyFormatOptions can make sense. Then fish it out of config before passing it through in options.

@SimenB
Copy link
Member

SimenB commented Aug 15, 2018

We can land this separately first, though 🙂

@maciej-ka wanna rebase this and update the changelog?

@SimenB
Copy link
Member

SimenB commented Sep 17, 2018

@maciej-ka ping 🙂

@SimenB
Copy link
Member

SimenB commented Sep 17, 2018

I did it myself, easy enough 🙂 Hopefully CI passes

@SimenB SimenB merged commit 67e4c82 into jestjs:master Sep 17, 2018
@SimenB
Copy link
Member

SimenB commented Sep 17, 2018

Ooops, [WIP] included in the merge commit 😅

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants